From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chris DeBruin <cdeb5783@gmail.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH] rtc: pcf85063: Add support for the PCF85063A device
Date: Tue, 19 Jul 2016 19:03:09 +0200 [thread overview]
Message-ID: <20160719170309.GN7132@piout.net> (raw)
In-Reply-To: <1468358146-18717-1-git-send-email-cdeb5783@gmail.com>
On 12/07/2016 at 17:15:46 -0400, Chris DeBruin wrote :
> The current rtc-pcf85063 driver only supports the PCF85063TP device.
> Using the existing driver on a PCF85063A will result in the time being
> set correctly into the RTC, but the RTC is held in the stopped state.
> Therefore, the time will no longer advance and no error is indicated.
>
> The PCF85063A device has a bigger memory map than the PCF85063TP.
> The existing driver make use of an address rollover condition,
> but the rollover point is different in the two devices.
>
> Signed-off-by: Chris DeBruin <cdeb5783@gmail.com>
> ---
> drivers/rtc/rtc-pcf85063.c | 48 +++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
Applied after fixing some whitespace issues, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2016-07-19 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 21:15 [rtc-linux] [PATCH] rtc: pcf85063: Add support for the PCF85063A device Chris DeBruin
2016-07-19 17:03 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719170309.GN7132@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=cdeb5783@gmail.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox