From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (mail.free-electrons.com. [62.4.15.54]) by gmr-mx.google.com with ESMTP id f71si947224wmf.2.2016.12.07.10.37.10 for ; Wed, 07 Dec 2016 10:37:10 -0800 (PST) Date: Wed, 7 Dec 2016 19:37:09 +0100 From: Alexandre Belloni To: Amelie DELAUNAY Cc: Mathieu Poirier , "a.zummo@towertech.it" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "linux@armlinux.org.uk" , "rtc-linux@googlegroups.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Gabriel FERNANDEZ Subject: [rtc-linux] Re: [PATCH 3/8] rtc: add STM32 RTC driver Message-ID: <20161207183709.tbkapu34ljlg4skp@piout.net> References: <1480687801-19525-2-git-send-email-amelie.delaunay@st.com> <1480687801-19525-5-git-send-email-amelie.delaunay@st.com> <20161202175646.GA3284@linaro.org> <15bea9e9-adcc-edb0-1bd1-33d395c72eec@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <15bea9e9-adcc-edb0-1bd1-33d395c72eec@st.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 05/12/2016 at 10:43:14 +0100, Amelie DELAUNAY wrote : > >> + > >> + device_init_wakeup(&pdev->dev, true); > > > > What happens if device_init_wakeup() returns an error? > It means that RTC won't be able to wake up the board with RTC alarm. I can > add a warning for the user in this case ? > > There is exactly one driver ever checking the return value of device_init_wakeup(). It basically always succeeds. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.