From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com MIME-Version: 1.0 Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.135]) by gmr-mx.google.com with ESMTPS id 133si170960wmj.1.2017.01.13.07.33.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jan 2017 07:33:48 -0800 (PST) From: Arnd Bergmann To: Alexandre Belloni Cc: Arnd Bergmann , Mark Brown , Alessandro Zummo , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Mathieu Poirier , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro Date: Fri, 13 Jan 2017 16:32:53 +0100 Message-Id: <20170113153311.2611510-3-arnd@arndb.de> In-Reply-To: <20170113153311.2611510-1-arnd@arndb.de> References: <20170113153311.2611510-1-arnd@arndb.de> Reply-To: rtc-linux@googlegroups.com Content-Type: text/plain; charset=UTF-8 List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Using the ~ operator on a BIT() constant results in a large 'unsigned long' constant that won't fit into an 'unsigned int' function argument on 64-bit architectures, resulting in a harmless build warning in x86 allmodconfig: drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe': drivers/rtc/rtc-stm32.c:651:51: error: large integer implicitly truncated to unsigned type [-Werror=overflow] regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP); This works around the warning by adding an explict cast to 'u32', but that is unfortunately a bit ugly and I feel there should be a better way to do this, possibly with some changes to either the bitops.h header or the regmap API. Cc: Mark Brown Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver") Signed-off-by: Arnd Bergmann --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 8c599f52124c..05d3dc89e55f 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -92,7 +92,7 @@ /* STM32_PWR_CR */ #define PWR_CR 0x00 /* STM32_PWR_CR bit field */ -#define PWR_CR_DBP BIT(8) +#define PWR_CR_DBP (u32)BIT(8) struct stm32_rtc { struct rtc_device *rtc_dev; -- 2.9.0 -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.