From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com. [2a00:1450:4010:c07::232]) by gmr-mx.google.com with ESMTPS id k74si1315363wmd.1.2017.04.03.07.30.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 07:30:23 -0700 (PDT) Received: by mail-lf0-x232.google.com with SMTP id h125so75195595lfe.0 for ; Mon, 03 Apr 2017 07:30:23 -0700 (PDT) Date: Mon, 3 Apr 2017 15:30:20 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Jonathan Cameron , Olof Johansson , bleung@chromium.org, martinez.javier@gmail.com, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Vic Yang Subject: [rtc-linux] Re: [PATCH 1/7] mfd: cros-ec: Fix host command buffer size Message-ID: <20170403143020.mti5vdig6vvlcb2d@dell> References: <20170324174407.25401-1-enric.balletbo@collabora.com> <20170324174407.25401-2-enric.balletbo@collabora.com> <20170403142357.2usczfylqbg6cgcx@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20170403142357.2usczfylqbg6cgcx@dell> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Mon, 03 Apr 2017, Lee Jones wrote: > On Fri, 24 Mar 2017, Enric Balletbo i Serra wrote: >=20 > > From: Vic Yang > >=20 > > For SPI, we can get up to 32 additional bytes for response preamble. > > The current overhead (2 bytes) may cause problems when we try to receiv= e > > a big response. Update it to 32 bytes. > >=20 > > Without this fix we could see a kernel BUG when we receive a big respon= se > > from the Chrome EC when is connected via SPI. > >=20 > > Signed-off-by: Vic Yang > > Tested-by: Enric Balletbo i Serra > > --- > >=20 > > This patch is a FIX, and I think that would be interesting see it mer= ged > > in this release cycle. This should go through the MFD tree and can be p= icked > > independently of the other patches. Lee Jones I think this is for you. > >=20 > > include/linux/mfd/cros_ec.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > Applied, thanks. Scrap that, I'll keep it with the set. > > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > > index b3e812f..3b16c90 100644 > > --- a/include/linux/mfd/cros_ec.h > > +++ b/include/linux/mfd/cros_ec.h > > @@ -35,10 +35,11 @@ > > * Max bus-specific overhead incurred by request/responses. > > * I2C requires 1 additional byte for requests. > > * I2C requires 2 additional bytes for responses. > > + * SPI requires up to 32 additional bytes for responses. > > * */ > > #define EC_PROTO_VERSION_UNKNOWN 0 > > #define EC_MAX_REQUEST_OVERHEAD 1 > > -#define EC_MAX_RESPONSE_OVERHEAD 2 > > +#define EC_MAX_RESPONSE_OVERHEAD 32 > > =20 > > /* > > * Command interface between EC and AP, for LPC, I2C and SPI interface= s. >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.