From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lee Jones <lee.jones@linaro.org>, Olof Johansson <olof@lixom.net>,
bleung@chromium.org
Cc: martinez.javier@gmail.com, Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
rtc-linux@googlegroups.com,
Stephen Barber <smbarber@chromium.org>
Subject: [rtc-linux] [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice
Date: Mon, 3 Apr 2017 18:35:36 +0200 [thread overview]
Message-ID: <20170403163536.25634-6-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20170403163536.25634-1-enric.balletbo@collabora.com>
From: Stephen Barber <smbarber@chromium.org>
If the EC supports RTC host commands, expose an RTC device.
Signed-off-by: Stephen Barber <smbarber@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes since v1:
- Use PLATFORM_DEVID_AUTO to add the subdevice.
drivers/mfd/cros_ec.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index bbc17ab..76874be 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -51,6 +51,10 @@ static const struct mfd_cell ec_pd_cell = {
.pdata_size = sizeof(pd_p),
};
+static const struct mfd_cell ec_rtc_cell = {
+ .name = "cros-ec-rtc",
+};
+
static irqreturn_t ec_irq_thread(int irq, void *data)
{
struct cros_ec_device *ec_dev = data;
@@ -238,6 +242,16 @@ static void cros_ec_sensors_register(struct cros_ec_device *ec_dev)
kfree(msg);
}
+static void cros_ec_rtc_register(struct cros_ec_device *ec_dev)
+{
+ int ret;
+
+ ret = mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_rtc_cell,
+ 1, NULL, 0, NULL);
+ if (ret)
+ dev_err(ec_dev->dev, "failed to add EC RTC\n");
+}
+
int cros_ec_register(struct cros_ec_device *ec_dev)
{
struct device *dev = ec_dev->dev;
@@ -287,6 +301,10 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
if (cros_ec_check_features(ec_dev, EC_FEATURE_MOTION_SENSE))
cros_ec_sensors_register(ec_dev);
+ /* Check whether this EC has RTC support */
+ if (cros_ec_check_features(ec_dev, EC_FEATURE_RTC))
+ cros_ec_rtc_register(ec_dev);
+
if (ec_dev->max_passthru) {
/*
* Register a PD device as well on top of this device.
--
2.9.3
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-04-03 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 16:35 [rtc-linux] [PATCH v2 0/5] mfd: cros-ec: Some fixes and improvements Enric Balletbo i Serra
2017-04-03 16:35 ` [rtc-linux] [PATCH v2 1/5] mfd: cros-ec: Fix host command buffer size Enric Balletbo i Serra
2017-04-11 9:18 ` [rtc-linux] " Lee Jones
2017-04-03 16:35 ` [rtc-linux] [PATCH v2 2/5] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev Enric Balletbo i Serra
2017-04-11 9:19 ` [rtc-linux] " Lee Jones
2017-04-20 9:40 ` Enric Balletbo i Serra
2017-04-03 16:35 ` [rtc-linux] [PATCH v2 3/5] mfd: cros_ec: Introduce RTC commands and events definitions Enric Balletbo i Serra
2017-04-03 16:35 ` [rtc-linux] [PATCH v2 4/5] rtc: cros-ec: add cros-ec-rtc driver Enric Balletbo i Serra
2017-04-03 16:35 ` Enric Balletbo i Serra [this message]
2017-04-11 9:48 ` [rtc-linux] Re: [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice Lee Jones
2017-04-20 9:59 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403163536.25634-6-enric.balletbo@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
--cc=smbarber@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox