From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com. [2a00:1450:400c:c0c::233]) by gmr-mx.google.com with ESMTPS id d184si520628wmc.0.2017.04.04.01.37.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 01:37:34 -0700 (PDT) Received: by mail-wr0-x233.google.com with SMTP id w11so202665147wrc.3 for ; Tue, 04 Apr 2017 01:37:34 -0700 (PDT) Date: Tue, 4 Apr 2017 09:37:29 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Jonathan Cameron , Olof Johansson , bleung@chromium.org, martinez.javier@gmail.com, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Vic Yang Subject: [rtc-linux] Re: [PATCH 1/7] mfd: cros-ec: Fix host command buffer size Message-ID: <20170404083729.7uvjbul64vnqg67e@dell> References: <20170324174407.25401-1-enric.balletbo@collabora.com> <20170324174407.25401-2-enric.balletbo@collabora.com> <20170403142357.2usczfylqbg6cgcx@dell> <20170403143020.mti5vdig6vvlcb2d@dell> <78c54848-3166-4531-2178-0fe73b94727a@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <78c54848-3166-4531-2178-0fe73b94727a@collabora.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote: >=20 >=20 > On 03/04/17 16:30, Lee Jones wrote: > > On Mon, 03 Apr 2017, Lee Jones wrote: > >=20 > >> On Fri, 24 Mar 2017, Enric Balletbo i Serra wrote: > >> > >>> From: Vic Yang > >>> > >>> For SPI, we can get up to 32 additional bytes for response preamble. > >>> The current overhead (2 bytes) may cause problems when we try to rece= ive > >>> a big response. Update it to 32 bytes. > >>> > >>> Without this fix we could see a kernel BUG when we receive a big resp= onse > >>> from the Chrome EC when is connected via SPI. > >>> > >>> Signed-off-by: Vic Yang > >>> Tested-by: Enric Balletbo i Serra > >>> --- > >>> > >>> This patch is a FIX, and I think that would be interesting see it m= erged > >>> in this release cycle. This should go through the MFD tree and can be= picked > >>> independently of the other patches. Lee Jones I think this is for you= . > >>> > >>> include/linux/mfd/cros_ec.h | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> Applied, thanks. > >=20 > > Scrap that, I'll keep it with the set. > >=20 >=20 > Ok, I'll send a v2 asap with this patch and the few modifications request= ed on > patch 7/7. I'm wondering though if this specific patch could go with curr= ent > release cycle as (explained above) is a fix and current kernel is affecte= d. Yes, but please send it property next time. I.e. On its own and with either a "Fixes:" tag or Cc stable. If you don't know what I'm talking about look it up in Documentation. > >>> diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.= h > >>> index b3e812f..3b16c90 100644 > >>> --- a/include/linux/mfd/cros_ec.h > >>> +++ b/include/linux/mfd/cros_ec.h > >>> @@ -35,10 +35,11 @@ > >>> * Max bus-specific overhead incurred by request/responses. > >>> * I2C requires 1 additional byte for requests. > >>> * I2C requires 2 additional bytes for responses. > >>> + * SPI requires up to 32 additional bytes for responses. > >>> * */ > >>> #define EC_PROTO_VERSION_UNKNOWN 0 > >>> #define EC_MAX_REQUEST_OVERHEAD 1 > >>> -#define EC_MAX_RESPONSE_OVERHEAD 2 > >>> +#define EC_MAX_RESPONSE_OVERHEAD 32 > >>> =20 > >>> /* > >>> * Command interface between EC and AP, for LPC, I2C and SPI interfa= ces. > >> > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.