From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com. [2a00:1450:400c:c09::230]) by gmr-mx.google.com with ESMTPS id k74si164552wmd.1.2017.04.11.02.48.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 02:48:28 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id o81so58643273wmb.1 for ; Tue, 11 Apr 2017 02:48:28 -0700 (PDT) Date: Tue, 11 Apr 2017 10:48:25 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Jonathan Cameron , Olof Johansson , bleung@chromium.org, martinez.javier@gmail.com, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Stephen Barber Subject: [rtc-linux] Re: [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice Message-ID: <20170411094825.64kwe5uckdpc3n4q@dell> References: <20170403163536.25634-1-enric.balletbo@collabora.com> <20170403163536.25634-6-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20170403163536.25634-6-enric.balletbo@collabora.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote: > From: Stephen Barber >=20 > If the EC supports RTC host commands, expose an RTC device. This could be made nicer by checking RTC compatibility in the RTC driver. So register it regardless, then check if the device is supported from within. If it's not supported simply return -ENODEV from probe. > Signed-off-by: Stephen Barber > Signed-off-by: Enric Balletbo i Serra > --- >=20 > Changes since v1: > - Use PLATFORM_DEVID_AUTO to add the subdevice. >=20 > drivers/mfd/cros_ec.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index bbc17ab..76874be 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -51,6 +51,10 @@ static const struct mfd_cell ec_pd_cell =3D { > .pdata_size =3D sizeof(pd_p), > }; > =20 > +static const struct mfd_cell ec_rtc_cell =3D { > + .name =3D "cros-ec-rtc", > +}; > + > static irqreturn_t ec_irq_thread(int irq, void *data) > { > struct cros_ec_device *ec_dev =3D data; > @@ -238,6 +242,16 @@ static void cros_ec_sensors_register(struct cros_ec_= device *ec_dev) > kfree(msg); > } > =20 > +static void cros_ec_rtc_register(struct cros_ec_device *ec_dev) > +{ > + int ret; > + > + ret =3D mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_rtc_cell, > + 1, NULL, 0, NULL); > + if (ret) > + dev_err(ec_dev->dev, "failed to add EC RTC\n"); > +} > + > int cros_ec_register(struct cros_ec_device *ec_dev) > { > struct device *dev =3D ec_dev->dev; > @@ -287,6 +301,10 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > if (cros_ec_check_features(ec_dev, EC_FEATURE_MOTION_SENSE)) > cros_ec_sensors_register(ec_dev); > =20 > + /* Check whether this EC has RTC support */ > + if (cros_ec_check_features(ec_dev, EC_FEATURE_RTC)) > + cros_ec_rtc_register(ec_dev); > + > if (ec_dev->max_passthru) { > /* > * Register a PD device as well on top of this device. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.