From: Mark Salyzyn <salyzyn@android.com>
To: linux-kernel@vger.kernel.org
Cc: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
linux-pm@vger.kernel.org, a.zummo@towertech.it,
alexandre.belloni@free-electrons.com, linux-rtc@vger.kernel.org,
Mark Salyzyn <salyzyn@android.com>
Subject: [PATCH v2 3/4] PM: Print wall time at suspend & hibernate entry and exit
Date: Wed, 19 Jul 2017 12:45:58 -0700 [thread overview]
Message-ID: <20170719194600.29210-1-salyzyn@android.com> (raw)
Permits power state and battery life diagnosis.
Since one is not guaranteed to have a persistent hardware clock to
report Suspended for in milliseconds, we report at a higher level
at just the entry and exit points for suspend and hibernate.
Feature activated by CONFIG_RTC_SHOW_TIME_*
Signed-off-by: Mark Salyzyn <salyzyn@android.com>
v2:
- merge suspend and hibernate into a single patch
---
kernel/power/hibernate.c | 4 +++-
kernel/power/suspend.c | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index e1914c7b85b1..0b5460f9189b 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -32,11 +32,11 @@
#include <linux/ctype.h>
#include <linux/genhd.h>
#include <linux/ktime.h>
+#include <linux/rtc.h>
#include <trace/events/power.h>
#include "power.h"
-
static int nocompress;
static int noresume;
static int nohibernate;
@@ -342,6 +342,7 @@ int hibernation_snapshot(int platform_mode)
pm_message_t msg;
int error;
+ rtc_show_time("PM: hibernation entry");
pm_suspend_clear_flags();
error = platform_begin(platform_mode);
if (error)
@@ -409,6 +410,7 @@ int hibernation_snapshot(int platform_mode)
thaw_kernel_threads();
Cleanup:
swsusp_free();
+ rtc_show_time("PM: hibernation exit");
goto Close;
}
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 3ecf275d7e44..f44d2152ab3f 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -26,6 +26,7 @@
#include <linux/suspend.h>
#include <linux/syscore_ops.h>
#include <linux/ftrace.h>
+#include <linux/rtc.h>
#include <trace/events/power.h>
#include <linux/compiler.h>
#include <linux/moduleparam.h>
@@ -579,6 +580,7 @@ int pm_suspend(suspend_state_t state)
if (state <= PM_SUSPEND_ON || state >= PM_SUSPEND_MAX)
return -EINVAL;
+ rtc_show_time("PM: suspend entry");
error = enter_state(state);
if (error) {
suspend_stats.fail++;
@@ -586,6 +588,7 @@ int pm_suspend(suspend_state_t state)
} else {
suspend_stats.success++;
}
+ rtc_show_time("PM: suspend exit");
return error;
}
EXPORT_SYMBOL(pm_suspend);
--
2.14.0.rc0.284.gd933b75aa4-goog
next reply other threads:[~2017-07-19 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 19:45 Mark Salyzyn [this message]
2017-07-19 20:40 ` [PATCH v2 3/4] PM: Print wall time at suspend & hibernate entry and exit Rafael J. Wysocki
2017-07-19 21:23 ` Mark Salyzyn
2017-07-19 21:31 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2017-07-19 19:48 Mark Salyzyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719194600.29210-1-salyzyn@android.com \
--to=salyzyn@android.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox