From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Matthias Fuchs <matthias.fuchs@esd-electronics.com>,
linux-rtc@vger.kernel.org
Subject: Re: Duplicated drivers for Epson RX8025 RTC support
Date: Mon, 24 Jul 2017 11:16:01 +0200 [thread overview]
Message-ID: <20170724091601.sjz5shnv3ozq6the@piout.net> (raw)
In-Reply-To: <a82c9f50-31d2-d750-39fc-05501f3724ad@gmail.com>
Hi,
On 23/07/2017 at 22:15:24 +0200, Heiner Kallweit wrote:
> When working on refactoring parts of the ds1307 I stumbled across the fact
> that there are two rtc drivers claiming to support the Epson RX8025 chip.
>
> 1. ds1307 claims to support also this chip. Support was added in 2009,
> however I have doubts that it actually works.
> RX8025 needs a special addressing mode (register address has to be
> left-shifted by 4 bits) which is implemented for both control
> registers but not for the standard registers.
>
> Also support for this chip misses the fix from patch 2e10e74df72
> ("rtc: rx8025: fix transfer mode")
>
> I'm curious whether support for this chip was ever tested, commit message
> of a216685818a5 "rtc: add EPSON RX8025 support to DS1307 RTC driver"
> does not mention that this piece of code was tested with any device
> with this chip.
>
> 2. There's a separate driver for this chip (rtc-rx8025), also added in 2009.
> This drivers is actively maintained.
>
> The separate driver mentions that it supports SA/NB variants of the chip.
> There's no info regarding supported chip variants in the ds1307-integrated
> driver. So there is a small chance that both drivers support different
> chip variants (in this case however the ds1307-integrated driver should
> clearly mention this, also in the Kconfig help text).
>
> For me it's more likely that both drivers try support the same chip.
> Having said that I would propose to remove (rudimentary) RX8025 support
> in ds1307. As a first step we could leave the code in but use a WARN_ON
> to notify potential users that this code is deprecated and they should
> use the separate driver instead.
>
The remaining issue is described here:
https://groups.google.com/d/msg/rtc-linux/M_uv9YkRbC8/MaKpMa3LGgAJ
It is even more apparent after your regmap rework.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-24 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 20:15 Duplicated drivers for Epson RX8025 RTC support Heiner Kallweit
2017-07-24 9:16 ` Alexandre Belloni [this message]
2017-07-24 20:15 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724091601.sjz5shnv3ozq6the@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=hkallweit1@gmail.com \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.fuchs@esd-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox