From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alexey Klimov <alexey.klimov@arm.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, maxime.ripard@free-electrons.com,
wens@csie.org, robh@kernel.org
Subject: Re: [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc_setalarm()
Date: Sun, 30 Jul 2017 16:41:28 +0200 [thread overview]
Message-ID: <20170730144128.2lvg6vxohsbmxw63@piout.net> (raw)
In-Reply-To: <1499857190-30849-3-git-send-email-alexey.klimov@arm.com>
Hi,
On 12/07/2017 at 11:59:50 +0100, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@arm.com>
> ---
> drivers/rtc/rtc-sun6i.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 77bc4d3..1886b85 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -362,7 +362,7 @@ static int sun6i_rtc_setalarm(struct device *dev, struct rtc_wkalrm *wkalrm)
> unsigned long time_now = 0;
> unsigned long time_set = 0;
> unsigned long time_gap = 0;
> - int ret = 0;
> + int ret;
>
I don't see any reason that would justify that change.
> ret = sun6i_rtc_gettime(dev, &tm_now);
> if (ret < 0) {
> --
> 1.9.1
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-30 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 10:59 [PATCH 1/3] rtc: sun6i: Remove double init of spinlock in sun6i_rtc_clk_init() Alexey Klimov
2017-07-12 10:59 ` [PATCH 2/3] rtc: sun6i: fix memleaks and add error-path " Alexey Klimov
2017-07-24 3:22 ` Chen-Yu Tsai
2017-07-12 10:59 ` [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc_setalarm() Alexey Klimov
2017-07-24 3:23 ` Chen-Yu Tsai
2017-07-30 14:41 ` Alexandre Belloni [this message]
2017-07-24 3:24 ` [PATCH 1/3] rtc: sun6i: Remove double init of spinlock in sun6i_rtc_clk_init() Chen-Yu Tsai
2017-07-30 14:40 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170730144128.2lvg6vxohsbmxw63@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=alexey.klimov@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).