From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: ying.zhang22455@nxp.com
Cc: rtc-linux@googlegroups.com, jiafei.pan@nxp.com
Subject: Re: [rtc-linux] [PATCH] drivers/rtc/rtc-pcf85263.c: add support for devicetree
Date: Sat, 16 Sep 2017 01:21:34 +0200 [thread overview]
Message-ID: <20170915232134.7nq34do64aqlprye@piout.net> (raw)
In-Reply-To: <20170906054403.18567-1-ying.zhang22455@nxp.com>
Hi,
This email was not send to the correct mailing list.
On 06/09/2017 at 13:44:03 +0800, ying.zhang22455@nxp.com wrote:
> From: Zhang Ying-22455 <ying.zhang22455@nxp.com>
>
> Add compatible string "nxp,rtc-pcf85263"
It doesn't add the compatible string anywhere.
> Document the binding
>
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> ---
> Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt b/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
> new file mode 100644
> index 000000000000..d2ffd3626f5c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
> @@ -0,0 +1,15 @@
> +NXP PCF85263 SPI Real Time Clock
> +
> +Required properties:
> +- compatible: should be: "nxp,rtc-pcf85263"
The proper compatible string would be "nxp,pcf85263"
Also, please have a look at
http://patchwork.ozlabs.org/patch/658956/
http://patchwork.ozlabs.org/patch/658957/
Martin never replied but you can probably push them again.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-09-15 23:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 5:44 [rtc-linux] [PATCH] drivers/rtc/rtc-pcf85263.c: add support for devicetree ying.zhang22455
2017-09-15 23:21 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915232134.7nq34do64aqlprye@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=jiafei.pan@nxp.com \
--cc=rtc-linux@googlegroups.com \
--cc=ying.zhang22455@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox