* [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130
@ 2017-10-17 12:46 Bastian Stender
2017-10-17 12:49 ` [rtc-linux] " Marek Vasut
2017-10-26 20:59 ` Alexandre Belloni
0 siblings, 2 replies; 5+ messages in thread
From: Bastian Stender @ 2017-10-17 12:46 UTC (permalink / raw)
To: rtc-linux
Cc: Marek Vasut, Alexandre Belloni, Arnd Bergmann, Felipe Balbi,
Nishanth Menon, Tony Lindgren, kernel, Bastian Stender
Make Epson RX8130 device tree and ACPI aware.
Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
Signed-off-by: Bastian Stender <bst@pengutronix.de>
---
drivers/rtc/rtc-ds1307.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index e7d9215c9201..8e2cd45a2f96 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -325,6 +325,10 @@ static const struct of_device_id ds1307_of_match[] = {
.compatible = "isil,isl12057",
.data = (void *)ds_1337
},
+ {
+ .compatible = "epson,rx8130",
+ .data = (void *)rx_8130
+ },
{ }
};
MODULE_DEVICE_TABLE(of, ds1307_of_match);
@@ -348,6 +352,7 @@ static const struct acpi_device_id ds1307_acpi_ids[] = {
{ .id = "PT7C4338", .driver_data = ds_1307 },
{ .id = "RX8025", .driver_data = rx_8025 },
{ .id = "ISL12057", .driver_data = ds_1337 },
+ { .id = "RX8130", .driver_data = rx_8130 },
{ }
};
MODULE_DEVICE_TABLE(acpi, ds1307_acpi_ids);
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130
2017-10-17 12:46 [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130 Bastian Stender
@ 2017-10-17 12:49 ` Marek Vasut
2017-10-17 12:55 ` Bastian Stender
2017-10-26 20:59 ` Alexandre Belloni
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2017-10-17 12:49 UTC (permalink / raw)
To: Bastian Stender, rtc-linux
Cc: Alexandre Belloni, Arnd Bergmann, Felipe Balbi, Nishanth Menon,
Tony Lindgren, kernel
On 10/17/2017 02:46 PM, Bastian Stender wrote:
> Make Epson RX8130 device tree and ACPI aware.
>
> Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
Fixes , really ? I don't think it's broken in any way without the ACPI
entries.
> Signed-off-by: Bastian Stender <bst@pengutronix.de>
> ---
> drivers/rtc/rtc-ds1307.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index e7d9215c9201..8e2cd45a2f96 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -325,6 +325,10 @@ static const struct of_device_id ds1307_of_match[] = {
> .compatible = "isil,isl12057",
> .data = (void *)ds_1337
> },
> + {
> + .compatible = "epson,rx8130",
> + .data = (void *)rx_8130
> + },
> { }
> };
> MODULE_DEVICE_TABLE(of, ds1307_of_match);
> @@ -348,6 +352,7 @@ static const struct acpi_device_id ds1307_acpi_ids[] = {
> { .id = "PT7C4338", .driver_data = ds_1307 },
> { .id = "RX8025", .driver_data = rx_8025 },
> { .id = "ISL12057", .driver_data = ds_1337 },
> + { .id = "RX8130", .driver_data = rx_8130 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, ds1307_acpi_ids);
>
--
Best regards,
Marek Vasut
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130
2017-10-17 12:49 ` [rtc-linux] " Marek Vasut
@ 2017-10-17 12:55 ` Bastian Stender
2017-10-17 13:00 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Bastian Stender @ 2017-10-17 12:55 UTC (permalink / raw)
To: Marek Vasut, rtc-linux
Cc: Nishanth Menon, Arnd Bergmann, Tony Lindgren, Felipe Balbi,
Alexandre Belloni, kernel
On 10/17/2017 02:49 PM, Marek Vasut wrote:
> On 10/17/2017 02:46 PM, Bastian Stender wrote:
>> Make Epson RX8130 device tree and ACPI aware.
>>
>> Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
>
> Fixes , really ? I don't think it's broken in any way without the ACPI
> entries.
I think it's incomplete without ACPI/OF support - all other devices do
have entries there. But yes, it is not really a bug, so this can discarded.
Regards,
Bastian
--
Pengutronix e.K.
Industrial Linux Solutions
http://www.pengutronix.de/
Peiner Str. 6-8, 31137 Hildesheim, Germany
Amtsgericht Hildesheim, HRA 2686
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130
2017-10-17 12:55 ` Bastian Stender
@ 2017-10-17 13:00 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2017-10-17 13:00 UTC (permalink / raw)
To: Bastian Stender, rtc-linux
Cc: Nishanth Menon, Arnd Bergmann, Tony Lindgren, Felipe Balbi,
Alexandre Belloni, kernel
On 10/17/2017 02:55 PM, Bastian Stender wrote:
> On 10/17/2017 02:49 PM, Marek Vasut wrote:
>> On 10/17/2017 02:46 PM, Bastian Stender wrote:
>>> Make Epson RX8130 device tree and ACPI aware.
>>>
>>> Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
>>
>> Fixes , really ? I don't think it's broken in any way without the ACPI
>> entries.
>
> I think it's incomplete without ACPI/OF support - all other devices do
> have entries there. But yes, it is not really a bug, so this can discarded.
Jupp, this patch is fine, it was just the "fixes" part which looked odd.
--
Best regards,
Marek Vasut
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130
2017-10-17 12:46 [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130 Bastian Stender
2017-10-17 12:49 ` [rtc-linux] " Marek Vasut
@ 2017-10-26 20:59 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2017-10-26 20:59 UTC (permalink / raw)
To: Bastian Stender
Cc: rtc-linux, Marek Vasut, Arnd Bergmann, Felipe Balbi,
Nishanth Menon, Tony Lindgren, kernel
Hi,
Note that this has not been sent to the correct mailing list (please use
a more recent kernel ;))
On 17/10/2017 at 14:46:07 +0200, Bastian Stender wrote:
> Make Epson RX8130 device tree and ACPI aware.
>
> Fixes: ee0981be7704 ("rtc: ds1307: Add support for Epson RX8130CE")
> Signed-off-by: Bastian Stender <bst@pengutronix.de>
> ---
> drivers/rtc/rtc-ds1307.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-26 20:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-17 12:46 [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130 Bastian Stender
2017-10-17 12:49 ` [rtc-linux] " Marek Vasut
2017-10-17 12:55 ` Bastian Stender
2017-10-17 13:00 ` Marek Vasut
2017-10-26 20:59 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).