* [PATCH] rtc: mxc_v2: remove __exit annotation
@ 2018-01-02 9:43 Arnd Bergmann
2018-01-11 23:12 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-01-02 9:43 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: Arnd Bergmann, Patrick Bruenn, linux-rtc, linux-kernel
The mxc_rtc_remove is incorrectly annotated as __exit:
`mxc_rtc_remove' referenced in section `.data' of drivers/rtc/rtc-mxc_v2.o: defined in discarded section `.exit.text' of drivers/rtc/rtc-mxc_v2.o
This should not be done, as devices can be dynamically bound
and unbound to a driver.
Fixes: 54c47014b474 ("rtc: add mxc driver for i.MX53 SRTC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/rtc/rtc-mxc_v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-mxc_v2.c b/drivers/rtc/rtc-mxc_v2.c
index b637095b0716..77a065e23a84 100644
--- a/drivers/rtc/rtc-mxc_v2.c
+++ b/drivers/rtc/rtc-mxc_v2.c
@@ -368,7 +368,7 @@ static int mxc_rtc_probe(struct platform_device *pdev)
return 0;
}
-static int __exit mxc_rtc_remove(struct platform_device *pdev)
+static int mxc_rtc_remove(struct platform_device *pdev)
{
struct mxc_rtc_data *pdata = platform_get_drvdata(pdev);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: mxc_v2: remove __exit annotation
2018-01-02 9:43 [PATCH] rtc: mxc_v2: remove __exit annotation Arnd Bergmann
@ 2018-01-11 23:12 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2018-01-11 23:12 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Alessandro Zummo, Patrick Bruenn, linux-rtc, linux-kernel
On 02/01/2018 at 10:43:33 +0100, Arnd Bergmann wrote:
> The mxc_rtc_remove is incorrectly annotated as __exit:
>
> `mxc_rtc_remove' referenced in section `.data' of drivers/rtc/rtc-mxc_v2.o: defined in discarded section `.exit.text' of drivers/rtc/rtc-mxc_v2.o
>
> This should not be done, as devices can be dynamically bound
> and unbound to a driver.
>
> Fixes: 54c47014b474 ("rtc: add mxc driver for i.MX53 SRTC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/rtc/rtc-mxc_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-11 23:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 9:43 [PATCH] rtc: mxc_v2: remove __exit annotation Arnd Bergmann
2018-01-11 23:12 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).