* [PATCH] rtc: ds1742: don't explicitly specify word_size and stride of nvmem
@ 2018-05-20 15:21 Uwe Kleine-König
2018-05-21 20:34 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2018-05-20 15:21 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni; +Cc: linux-rtc, kernel
nvmem_register() assumes these values to be 1 if unset, so they don't
need to be set explicitly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/rtc/rtc-ds1742.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
index 2d781180e968..939c2506bcd5 100644
--- a/drivers/rtc/rtc-ds1742.c
+++ b/drivers/rtc/rtc-ds1742.c
@@ -154,8 +154,6 @@ static int ds1742_rtc_probe(struct platform_device *pdev)
int ret = 0;
struct nvmem_config nvmem_cfg = {
.name = "ds1742_nvram",
- .word_size = 1,
- .stride = 1,
.reg_read = ds1742_nvram_read,
.reg_write = ds1742_nvram_write,
};
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: ds1742: don't explicitly specify word_size and stride of nvmem
2018-05-20 15:21 [PATCH] rtc: ds1742: don't explicitly specify word_size and stride of nvmem Uwe Kleine-König
@ 2018-05-21 20:34 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2018-05-21 20:34 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Alessandro Zummo, linux-rtc, kernel
On 20/05/2018 17:21:45+0200, Uwe Kleine-König wrote:
> nvmem_register() assumes these values to be 1 if unset, so they don't
> need to be set explicitly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/rtc/rtc-ds1742.c | 2 --
> 1 file changed, 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-21 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-20 15:21 [PATCH] rtc: ds1742: don't explicitly specify word_size and stride of nvmem Uwe Kleine-König
2018-05-21 20:34 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).