From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:60764 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbeETUIL (ORCPT ); Sun, 20 May 2018 16:08:11 -0400 Date: Sun, 20 May 2018 22:08:09 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] rtc: pcf2127: add support for accessing internal static RAM Message-ID: <20180520200809.GE23730@piout.net> References: <20180520133723.30547-1-u.kleine-koenig@pengutronix.de> <20180520180520.GC23730@piout.net> <20180520184001.xcgn4b6aijvfzu37@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20180520184001.xcgn4b6aijvfzu37@pengutronix.de> Sender: linux-rtc-owner@vger.kernel.org List-ID: On 20/05/2018 20:40:01+0200, Uwe Kleine-König wrote: > Hello Alexandre, > > On Sun, May 20, 2018 at 08:05:20PM +0200, Alexandre Belloni wrote: > > On 20/05/2018 15:37:23+0200, Uwe Kleine-König wrote: > > > @@ -200,8 +242,21 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, > > > > > > pcf2127->rtc = devm_rtc_device_register(dev, name, &pcf2127_rtc_ops, > > > THIS_MODULE); > > > + if (IS_ERR(pcf2127->rtc)) > > > + return PTR_ERR(pcf2127->rtc); > > > + > > > + if (has_nvmem) { > > > + struct nvmem_config nvmem_cfg = { > > > + .priv = pcf2127, > > > + .reg_read = pcf2127_nvmem_read, > > > + .reg_write = pcf2127_nvmem_write, > > > + .size = 512, > > > + }; > > > + > > > + ret = rtc_nvmem_register(pcf2127->rtc, &nvmem_cfg); > > > + } > > > > > > - return PTR_ERR_OR_ZERO(pcf2127->rtc); > > > + return ret; > > > > You must not return an error here once devm_rtc_device_register has > > succeeded. > > Why? Sounds like something that should be fixed. > This is the explanation: http://patchwork.ozlabs.org/patch/324263/ -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com