From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:39692 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934877AbeE2QGt (ORCPT ); Tue, 29 May 2018 12:06:49 -0400 Date: Tue, 29 May 2018 18:06:47 +0200 From: Maxime Ripard To: Jagan Teki Cc: Alessandro Zummo , Alexandre Belloni , Chen-Yu Tsai , Michael Trimarchi , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2] rtc: sun6i: Fix bit_idx value for clk_register_gate Message-ID: <20180529160647.ene36dc7iacyppia@flea.home> References: <20180529160425.23697-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180529160425.23697-1-jagan@amarulasolutions.com> Sender: linux-rtc-owner@vger.kernel.org List-ID: On Tue, May 29, 2018 at 09:34:25PM +0530, Jagan Teki wrote: > From: Michael Trimarchi > > clk-gate core will take bit_idx through clk_register_gate > and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i > is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx) > which is wrong and eventually external gate clock is not enabling. > > This patch fixed by passing bit index and the original change > introduced from below commit. > "rtc: sun6i: Add support for the external oscillator gate" > (sha1: 17ecd246414b3a0fe0cb248c86977a8bda465b7b) > > Signed-off-by: Michael Trimarchi > Signed-off-by: Jagan Teki I said it in the v1 already, but this should be sent to stable and have a fixes tag. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com