[PATCH 0/9] croc_ec: Switch to SPDX identifier

[PATCH 0/9] croc_ec: Switch to SPDX identifier

[Enric Balletbo i Serra]

Dear all,

This patchset is just to adopt the SPDX license identifier for all
ChromeOS Embedded Controller related drivers. The patches touches
different subsystems but every patch can be picked from their respective
maintainer independently.

Thanks,
 Enric

Enric Balletbo i Serra (9):
  platform/chrome: cros_ec: Switch to SPDX identifier.
  platform/chrome: pstore: Switch to SPDX identifier.
  mfd: cros_ec: Add or fix SPDX-License-Identifier in all files.
  iio: cros_ec: Switch to SPDX identifier.
  rtc: cros-ec: Switch to SPDX identifier.
  Input: cros_ec_keyb - Switch to SPDX identifier.
  pwm: cros-ec: Switch to SPDX identifier.
  extcon: usbc-cros-ec: Switch to SPDX identifier.
  i2c: i2c-cros-ec-tunnel: Switch to SPDX identifier.

 drivers/extcon/extcon-usbc-cros-ec.c          | 20 ++++----------
 drivers/i2c/busses/i2c-cros-ec-tunnel.c       | 14 +++-------
 drivers/iio/accel/cros_ec_accel_legacy.c      | 23 ++++------------
 .../common/cros_ec_sensors/cros_ec_sensors.c  | 24 +++++------------
 .../cros_ec_sensors/cros_ec_sensors_core.c    | 18 +++----------
 .../cros_ec_sensors/cros_ec_sensors_core.h    | 12 ++-------
 drivers/iio/light/cros_ec_light_prox.c        | 18 +++----------
 drivers/iio/pressure/cros_ec_baro.c           | 18 +++----------
 drivers/input/keyboard/cros_ec_keyb.c         | 26 +++---------------
 drivers/mfd/cros_ec.c                         | 27 +++++++------------
 drivers/mfd/cros_ec_dev.c                     | 24 +++++------------
 drivers/mfd/cros_ec_dev.h                     | 16 ++---------
 drivers/mfd/cros_ec_i2c.c                     | 19 ++++---------
 drivers/mfd/cros_ec_spi.c                     | 21 +++++----------
 drivers/platform/chrome/chromeos_pstore.c     | 13 +++------
 drivers/platform/chrome/cros_ec_debugfs.c     | 22 +++------------
 drivers/platform/chrome/cros_ec_lightbar.c    | 22 +++------------
 drivers/platform/chrome/cros_ec_lpc.c         | 26 +++---------------
 drivers/platform/chrome/cros_ec_lpc_mec.c     | 26 +++---------------
 drivers/platform/chrome/cros_ec_lpc_reg.c     | 26 +++---------------
 drivers/platform/chrome/cros_ec_proto.c       | 19 +++----------
 drivers/platform/chrome/cros_ec_sysfs.c       | 22 +++------------
 drivers/platform/chrome/cros_ec_vbc.c         | 24 ++++-------------
 .../platform/chrome/cros_kbd_led_backlight.c  | 19 +++----------
 drivers/pwm/pwm-cros-ec.c                     | 13 +++------
 drivers/rtc/rtc-cros-ec.c                     | 21 ++++-----------
 include/linux/mfd/cros_ec.h                   | 10 +------
 include/linux/mfd/cros_ec_commands.h          | 10 +------
 include/linux/mfd/cros_ec_lpc_mec.h           | 12 ++-------
 include/linux/mfd/cros_ec_lpc_reg.h           | 12 ++-------
 30 files changed, 123 insertions(+), 454 deletions(-)

-- 
2.17.1

[PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Enric Balletbo i Serra]

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c
index bf7ced095c94..e42e863b203a 100644
--- a/drivers/rtc/rtc-cros-ec.c
+++ b/drivers/rtc/rtc-cros-ec.c
@@ -1,19 +1,8 @@
-/*
- * RTC driver for Chrome OS Embedded Controller
- *
- * Copyright (c) 2017, Google, Inc
- *
- * Author: Stephen Barber <smbarber@chromium.org>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+// RTC driver for ChromeOS Embedded Controller.
+//
+// Copyright (C) 2017 Google, Inc.
+// Author: Stephen Barber <smbarber@chromium.org>
 
 #include <linux/kernel.h>
 #include <linux/mfd/cros_ec.h>
-- 
2.17.1

Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Alexandre Belloni]

On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> 
>  drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
>  1 file changed, 5 insertions(+), 16 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Enric Balletbo i Serra]

Hi Alexandre,

On 05/06/18 11:46, Alexandre Belloni wrote:
> On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
>> Adopt the SPDX license identifier headers to ease license compliance
>> management.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>>  drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
>>  1 file changed, 5 insertions(+), 16 deletions(-)
>>
> Applied, thanks.
> 

Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was
a mismatch between what the header says and the MODULE_LICENSE and I wrongly
assumed that the MODULE_LICENSE is the one I should follow. So could you not
apply this patch for now and I'll send another version with the correct license?

Thanks and sorry for the inconvenience this may cause you,
 Enric

Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Alexandre Belloni]

On 05/06/2018 20:51:06+0200, Enric Balletbo i Serra wrote:
> Hi Alexandre,
> 
> On 05/06/18 11:46, Alexandre Belloni wrote:
> > On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
> >> Adopt the SPDX license identifier headers to ease license compliance
> >> management.
> >>
> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >> ---
> >>
> >>  drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
> >>  1 file changed, 5 insertions(+), 16 deletions(-)
> >>
> > Applied, thanks.
> > 
> 
> Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was
> a mismatch between what the header says and the MODULE_LICENSE and I wrongly
> assumed that the MODULE_LICENSE is the one I should follow. So could you not
> apply this patch for now and I'll send another version with the correct license?
> 

Hum, ok, this seemed to be the correct way to solve the mismatch to me.


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Greg KH]

On Tue, Jun 05, 2018 at 08:59:52PM +0200, Alexandre Belloni wrote:
> On 05/06/2018 20:51:06+0200, Enric Balletbo i Serra wrote:
> > Hi Alexandre,
> > 
> > On 05/06/18 11:46, Alexandre Belloni wrote:
> > > On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
> > >> Adopt the SPDX license identifier headers to ease license compliance
> > >> management.
> > >>
> > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > >> ---
> > >>
> > >>  drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
> > >>  1 file changed, 5 insertions(+), 16 deletions(-)
> > >>
> > > Applied, thanks.
> > > 
> > 
> > Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was
> > a mismatch between what the header says and the MODULE_LICENSE and I wrongly
> > assumed that the MODULE_LICENSE is the one I should follow. So could you not
> > apply this patch for now and I'll send another version with the correct license?
> > 
> 
> Hum, ok, this seemed to be the correct way to solve the mismatch to me.

No, the license text trumps the MODULE_LICENSE() string.  Please revert
this, or fix it up to be correct.

thanks,

greg k-h

Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Alexandre Belloni]

On 25/06/2018 09:58:32+0800, Greg KH wrote:
> On Tue, Jun 05, 2018 at 08:59:52PM +0200, Alexandre Belloni wrote:
> > On 05/06/2018 20:51:06+0200, Enric Balletbo i Serra wrote:
> > > Hi Alexandre,
> > > 
> > > On 05/06/18 11:46, Alexandre Belloni wrote:
> > > > On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
> > > >> Adopt the SPDX license identifier headers to ease license compliance
> > > >> management.
> > > >>
> > > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > > >> ---
> > > >>
> > > >>  drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
> > > >>  1 file changed, 5 insertions(+), 16 deletions(-)
> > > >>
> > > > Applied, thanks.
> > > > 
> > > 
> > > Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was
> > > a mismatch between what the header says and the MODULE_LICENSE and I wrongly
> > > assumed that the MODULE_LICENSE is the one I should follow. So could you not
> > > apply this patch for now and I'll send another version with the correct license?
> > > 
> > 
> > Hum, ok, this seemed to be the correct way to solve the mismatch to me.
> 
> No, the license text trumps the MODULE_LICENSE() string.  Please revert
> this, or fix it up to be correct.
> 

Isn't it correct in Linus' tree?


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.

[Greg KH]

On Mon, Jun 25, 2018 at 09:34:59AM +0200, Alexandre Belloni wrote:
> On 25/06/2018 09:58:32+0800, Greg KH wrote:
> > On Tue, Jun 05, 2018 at 08:59:52PM +0200, Alexandre Belloni wrote:
> > > On 05/06/2018 20:51:06+0200, Enric Balletbo i Serra wrote:
> > > > Hi Alexandre,
> > > > 
> > > > On 05/06/18 11:46, Alexandre Belloni wrote:
> > > > > On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
> > > > >> Adopt the SPDX license identifier headers to ease license compliance
> > > > >> management.
> > > > >>
> > > > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > > > >> ---
> > > > >>
> > > > >>  drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
> > > > >>  1 file changed, 5 insertions(+), 16 deletions(-)
> > > > >>
> > > > > Applied, thanks.
> > > > > 
> > > > 
> > > > Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was
> > > > a mismatch between what the header says and the MODULE_LICENSE and I wrongly
> > > > assumed that the MODULE_LICENSE is the one I should follow. So could you not
> > > > apply this patch for now and I'll send another version with the correct license?
> > > > 
> > > 
> > > Hum, ok, this seemed to be the correct way to solve the mismatch to me.
> > 
> > No, the license text trumps the MODULE_LICENSE() string.  Please revert
> > this, or fix it up to be correct.
> > 
> 
> Isn't it correct in Linus' tree?

Looks good to me now, sorry for the noise.

greg k-h