From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new4-smtp.messagingengine.com ([66.111.4.230]:39255 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932129AbeFYLNB (ORCPT ); Mon, 25 Jun 2018 07:13:01 -0400 Date: Mon, 25 Jun 2018 19:06:40 +0800 From: Greg KH To: Alexandre Belloni Cc: Enric Balletbo i Serra , linux-kernel@vger.kernel.org, Gwendal Grignou , kernel@collabora.com, linux-rtc@vger.kernel.org, Alessandro Zummo Subject: Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier. Message-ID: <20180625110640.GC3058@kroah.com> References: <20180605092209.22887-1-enric.balletbo@collabora.com> <20180605092209.22887-6-enric.balletbo@collabora.com> <20180605094626.GC4637@piout.net> <39af6363-ce08-a227-f66a-4c7bd4916596@collabora.com> <20180605185952.GG4637@piout.net> <20180625015832.GB30408@kroah.com> <20180625073459.GA15406@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180625073459.GA15406@piout.net> Sender: linux-rtc-owner@vger.kernel.org List-ID: On Mon, Jun 25, 2018 at 09:34:59AM +0200, Alexandre Belloni wrote: > On 25/06/2018 09:58:32+0800, Greg KH wrote: > > On Tue, Jun 05, 2018 at 08:59:52PM +0200, Alexandre Belloni wrote: > > > On 05/06/2018 20:51:06+0200, Enric Balletbo i Serra wrote: > > > > Hi Alexandre, > > > > > > > > On 05/06/18 11:46, Alexandre Belloni wrote: > > > > > On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote: > > > > >> Adopt the SPDX license identifier headers to ease license compliance > > > > >> management. > > > > >> > > > > >> Signed-off-by: Enric Balletbo i Serra > > > > >> --- > > > > >> > > > > >> drivers/rtc/rtc-cros-ec.c | 21 +++++---------------- > > > > >> 1 file changed, 5 insertions(+), 16 deletions(-) > > > > >> > > > > > Applied, thanks. > > > > > > > > > > > > > Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was > > > > a mismatch between what the header says and the MODULE_LICENSE and I wrongly > > > > assumed that the MODULE_LICENSE is the one I should follow. So could you not > > > > apply this patch for now and I'll send another version with the correct license? > > > > > > > > > > Hum, ok, this seemed to be the correct way to solve the mismatch to me. > > > > No, the license text trumps the MODULE_LICENSE() string. Please revert > > this, or fix it up to be correct. > > > > Isn't it correct in Linus' tree? Looks good to me now, sorry for the noise. greg k-h