From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:55069 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725833AbeGLJjm (ORCPT ); Thu, 12 Jul 2018 05:39:42 -0400 Date: Thu, 12 Jul 2018 11:30:46 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Wim Van Sebroeck , Guenter Roeck , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel@pengutronix.de, NXP Linux Team Subject: Re: [PATCH] rtc: stmp3xxx: Don't reset the rtc in .probe() when watchdog is running Message-ID: <20180712093045.GB16084@piout.net> References: <20180609064313.18763-1-u.kleine-koenig@pengutronix.de> <20180709083041.m3h3smfaahl4awq4@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20180709083041.m3h3smfaahl4awq4@pengutronix.de> Sender: linux-rtc-owner@vger.kernel.org List-ID: On 09/07/2018 10:30:41+0200, Uwe Kleine-König wrote: > Hello, > > On Sat, Jun 09, 2018 at 08:43:13AM +0200, Uwe Kleine-König wrote: > > As pointed out in the added comment resetting the rtc also stops the > > included watchdog. This is bad if the bootloader started the watchdog to > > secure the boot process. So don't reset if the watchdog is running. > > I didn't get any feedback for this patch yet. Assuming my patch is > considered ok, my expectation would be that the watchdog people ack it > and that then it goes in via the rtc tree. > I actually applied it a while ago and forgot to say so. I've included Guenter's ack now. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com