From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com ([209.85.208.194]:45168 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730598AbeGSLGT (ORCPT ); Thu, 19 Jul 2018 07:06:19 -0400 Date: Thu, 19 Jul 2018 12:23:36 +0200 From: Johan Hovold To: Keerthy Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, t-kristo@ti.com, linux-rtc@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, johan@kernel.org Subject: Re: [PATCH v4 1/4] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec Message-ID: <20180719102336.GA19245@localhost> References: <1531372060-10532-1-git-send-email-j-keerthy@ti.com> <1531372060-10532-2-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1531372060-10532-2-git-send-email-j-keerthy@ti.com> Sender: linux-rtc-owner@vger.kernel.org List-ID: On Thu, Jul 12, 2018 at 10:37:37AM +0530, Keerthy wrote: > Cut down the shutdown time from 2 seconds to 1 sec. In case of roll > over try again. > > Signed-off-by: Keerthy > @@ -435,17 +435,23 @@ static void omap_rtc_power_off(void) > + /* set alarm one second from now */ > omap_rtc_read_time_raw(rtc, &tm); > + seconds = tm.tm_sec; > bcd2tm(&tm); > rtc_tm_to_time(&tm, &now); > - rtc_time_to_tm(now + 2, &tm); > + rtc_time_to_tm(now + 1, &tm); One more thing, the comment before final mdelay as well as that delay itself also needs to be updated to reflect this change. Thanks, Johan