From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Alvin Šipraga" <alvin@airtame.com>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
rkhudolii@airtame.com, attila@airtame.com
Subject: Re: [PATCH] rtc: pcf85063: preserve control register value between stop and start
Date: Sat, 28 Jul 2018 14:51:20 +0200 [thread overview]
Message-ID: <20180728125120.GA28585@piout.net> (raw)
In-Reply-To: <20180715213153.8606-1-alvin@airtame.com>
On 15/07/2018 23:31:53+0200, Alvin Šipraga wrote:
> Fix a bug that caused the Control_1 register to get zeroed whenever the
> RTC time is set. The problem occurred between stopping and starting the
> RTC clock, wherein the return value of a successful I2C write function
> would get written to the register.
>
> Also update variables of the start and stop functions to be more
> consistent with the rest of the driver.
>
> Signed-off-by: Alvin Šipraga <alvin@airtame.com>
> ---
> drivers/rtc/rtc-pcf85063.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-07-28 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 21:31 [PATCH] rtc: pcf85063: preserve control register value between stop and start Alvin Šipraga
2018-07-28 12:51 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728125120.GA28585@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=alvin@airtame.com \
--cc=attila@airtame.com \
--cc=linux-rtc@vger.kernel.org \
--cc=rkhudolii@airtame.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).