* [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC
@ 2018-08-20 18:07 Paul Cercueil
2018-08-20 19:12 ` Alexandre Belloni
2018-08-27 21:00 ` Alexandre Belloni
0 siblings, 2 replies; 5+ messages in thread
From: Paul Cercueil @ 2018-08-20 18:07 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: od, linux-rtc, linux-kernel, Paul Cercueil
Depending on MACH_INGENIC prevent us from creating a generic kernel that
works on more than one MIPS board. Instead, we just depend on MIPS being
set.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/rtc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index a2ba5db36145..98c7f19256b1 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1608,7 +1608,7 @@ config RTC_DRV_MPC5121
config RTC_DRV_JZ4740
tristate "Ingenic JZ4740 SoC"
- depends on MACH_INGENIC || COMPILE_TEST
+ depends on MIPS || COMPILE_TEST
help
If you say yes here you get support for the Ingenic JZ47xx SoCs RTC
controllers.
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC
2018-08-20 18:07 [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC Paul Cercueil
@ 2018-08-20 19:12 ` Alexandre Belloni
2018-08-20 19:18 ` Paul Cercueil
2018-08-27 21:00 ` Alexandre Belloni
1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2018-08-20 19:12 UTC (permalink / raw)
To: Paul Cercueil; +Cc: Alessandro Zummo, od, linux-rtc, linux-kernel
On 20/08/2018 20:07:16+0200, Paul Cercueil wrote:
> Depending on MACH_INGENIC prevent us from creating a generic kernel that
> works on more than one MIPS board. Instead, we just depend on MIPS being
> set.
Maybe you could consider dropping the whole dependency as we already
know it will build on every architecture.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/rtc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index a2ba5db36145..98c7f19256b1 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1608,7 +1608,7 @@ config RTC_DRV_MPC5121
>
> config RTC_DRV_JZ4740
> tristate "Ingenic JZ4740 SoC"
> - depends on MACH_INGENIC || COMPILE_TEST
> + depends on MIPS || COMPILE_TEST
> help
> If you say yes here you get support for the Ingenic JZ47xx SoCs RTC
> controllers.
> --
> 2.11.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC
2018-08-20 19:12 ` Alexandre Belloni
@ 2018-08-20 19:18 ` Paul Cercueil
2018-08-20 19:50 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Paul Cercueil @ 2018-08-20 19:18 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Alessandro Zummo, od, linux-rtc, linux-kernel
Hi,
Le lun. 20 ao=FBt 2018 =E0 21:12, Alexandre Belloni=20
<alexandre.belloni@bootlin.com> a =E9crit :
> On 20/08/2018 20:07:16+0200, Paul Cercueil wrote:
>> Depending on MACH_INGENIC prevent us from creating a generic kernel=20
>> that
>> works on more than one MIPS board. Instead, we just depend on MIPS=20
>> being
>> set.
>=20
> Maybe you could consider dropping the whole dependency as we already
> know it will build on every architecture.
Well, I didn't really want the Kconfig option to show on the menu when
compiling for non-MIPS, since it's only ever useful there.
Should I drop the dependency then?
>>=20
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> drivers/rtc/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>> index a2ba5db36145..98c7f19256b1 100644
>> --- a/drivers/rtc/Kconfig
>> +++ b/drivers/rtc/Kconfig
>> @@ -1608,7 +1608,7 @@ config RTC_DRV_MPC5121
>>=20
>> config RTC_DRV_JZ4740
>> tristate "Ingenic JZ4740 SoC"
>> - depends on MACH_INGENIC || COMPILE_TEST
>> + depends on MIPS || COMPILE_TEST
>> help
>> If you say yes here you get support for the Ingenic JZ47xx SoCs=20
>> RTC
>> controllers.
>> --
>> 2.11.0
>>=20
>=20
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
=
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC
2018-08-20 19:18 ` Paul Cercueil
@ 2018-08-20 19:50 ` Alexandre Belloni
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2018-08-20 19:50 UTC (permalink / raw)
To: Paul Cercueil; +Cc: Alessandro Zummo, od, linux-rtc, linux-kernel
On 20/08/2018 21:18:17+0200, Paul Cercueil wrote:
> Hi,
>
> Le lun. 20 août 2018 à 21:12, Alexandre Belloni
> <alexandre.belloni@bootlin.com> a écrit :
> > On 20/08/2018 20:07:16+0200, Paul Cercueil wrote:
> > > Depending on MACH_INGENIC prevent us from creating a generic kernel
> > > that
> > > works on more than one MIPS board. Instead, we just depend on MIPS
> > > being
> > > set.
> >
> > Maybe you could consider dropping the whole dependency as we already
> > know it will build on every architecture.
>
> Well, I didn't really want the Kconfig option to show on the menu when
> compiling for non-MIPS, since it's only ever useful there.
>
> Should I drop the dependency then?
>
No, I don't mind.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC
2018-08-20 18:07 [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC Paul Cercueil
2018-08-20 19:12 ` Alexandre Belloni
@ 2018-08-27 21:00 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2018-08-27 21:00 UTC (permalink / raw)
To: Paul Cercueil; +Cc: Alessandro Zummo, od, linux-rtc, linux-kernel
On 20/08/2018 20:07:16+0200, Paul Cercueil wrote:
> Depending on MACH_INGENIC prevent us from creating a generic kernel that
> works on more than one MIPS board. Instead, we just depend on MIPS being
> set.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/rtc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-28 0:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-20 18:07 [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC Paul Cercueil
2018-08-20 19:12 ` Alexandre Belloni
2018-08-20 19:18 ` Paul Cercueil
2018-08-20 19:50 ` Alexandre Belloni
2018-08-27 21:00 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).