From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:52247 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbeH1Aks (ORCPT ); Mon, 27 Aug 2018 20:40:48 -0400 Date: Mon, 27 Aug 2018 22:52:31 +0200 From: Alexandre Belloni To: Jia-Ju Bai Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: rtc-mrst: Replace mdelay() with msleep() in mrst_read_time() Message-ID: <20180827205231.GA24549@piout.net> References: <20180730135903.9442-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180730135903.9442-1-baijiaju1990@gmail.com> Sender: linux-rtc-owner@vger.kernel.org List-ID: On 30/07/2018 21:59:03+0800, Jia-Ju Bai wrote: > mrst_read_time() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > --- > drivers/rtc/rtc-mrst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com