From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8B4C67863 for ; Mon, 22 Oct 2018 17:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9343B20645 for ; Mon, 22 Oct 2018 17:28:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9343B20645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rtc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728791AbeJWBrw (ORCPT ); Mon, 22 Oct 2018 21:47:52 -0400 Received: from mail.bootlin.com ([62.4.15.54]:55888 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728629AbeJWBrv (ORCPT ); Mon, 22 Oct 2018 21:47:51 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 921B420E02; Mon, 22 Oct 2018 19:28:25 +0200 (CEST) Received: from localhost (unknown [185.7.230.214]) by mail.bootlin.com (Postfix) with ESMTPSA id 553AA20E01; Mon, 22 Oct 2018 19:28:15 +0200 (CEST) Date: Mon, 22 Oct 2018 19:28:15 +0200 From: Alexandre Belloni To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Joshua Kinard , Alessandro Zummo , linux-rtc@vger.kernel.org Subject: Re: [PATCH 1/1] rtc: ds1685: simplify getting .driver_data Message-ID: <20181022172815.GW17341@piout.net> References: <20181021200042.1993-1-wsa+renesas@sang-engineering.com> <20181021200042.1993-2-wsa+renesas@sang-engineering.com> <20181022155335.GT17341@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181022155335.GT17341@piout.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 22/10/2018 17:53:35+0200, Alexandre Belloni wrote: > On 21/10/2018 22:00:41+0200, Wolfram Sang wrote: > > We should get 'driver_data' from 'struct device' directly. Going via > > platform_device is an unneeded step back and forth. > > > > Signed-off-by: Wolfram Sang > > --- > > > > Build tested only. buildbot is happy. > > > > drivers/rtc/rtc-ds1685.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > Applied, thanks. > By the way, is there any reason why this was not part of your patch back in April? I had a deja vu feeling ;) -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com