From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Xulin Sun <xulin.sun@windriver.com>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, xulinsun@gmail.com
Subject: Re: [PATCH] rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write
Date: Wed, 7 Nov 2018 17:23:54 +0100 [thread overview]
Message-ID: <20181107162354.GE21694@piout.net> (raw)
In-Reply-To: <1541493739-85733-1-git-send-email-xulin.sun@windriver.com>
On 06/11/2018 16:42:19+0800, Xulin Sun wrote:
> pcf2127_i2c_gather_write() allocates memory as local variable
> for i2c_master_send(), after finishing the master transfer,
> the allocated memory should be freed. The kmemleak is reported:
>
> unreferenced object 0xffff80231e7dba80 (size 64):
> comm "hwclock", pid 27762, jiffies 4296880075 (age 356.944s)
> hex dump (first 32 bytes):
> 03 00 12 03 19 02 11 13 00 80 98 18 00 00 ff ff ................
> 00 50 00 00 00 00 00 00 02 00 00 00 00 00 00 00 .P..............
> backtrace:
> [<ffff000008221398>] create_object+0xf8/0x278
> [<ffff000008a96264>] kmemleak_alloc+0x74/0xa0
> [<ffff00000821070c>] __kmalloc+0x1ac/0x348
> [<ffff0000087ed1dc>] pcf2127_i2c_gather_write+0x54/0xf8
> [<ffff0000085fd9d4>] _regmap_raw_write+0x464/0x850
> [<ffff0000085fe3f4>] regmap_bulk_write+0x1a4/0x348
> [<ffff0000087ed32c>] pcf2127_rtc_set_time+0xac/0xe8
> [<ffff0000087eaad8>] rtc_set_time+0x80/0x138
> [<ffff0000087ebfb0>] rtc_dev_ioctl+0x398/0x610
> [<ffff00000823f2c0>] do_vfs_ioctl+0xb0/0x848
> [<ffff00000823fae4>] SyS_ioctl+0x8c/0xa8
> [<ffff000008083ac0>] el0_svc_naked+0x34/0x38
> [<ffffffffffffffff>] 0xffffffffffffffff
>
> Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
> ---
> drivers/rtc/rtc-pcf2127.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-07 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 8:42 [PATCH] rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write Xulin Sun
2018-11-07 16:23 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107162354.GE21694@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=xulin.sun@windriver.com \
--cc=xulinsun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).