From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: rv3028: new driver
Date: Wed, 13 Feb 2019 00:21:32 +0100 [thread overview]
Message-ID: <20190212232132.GG10129@piout.net> (raw)
In-Reply-To: <a40fd8e7-bf76-5a1f-3015-b15b72ac78ee@denx.de>
On 30/01/2019 17:13:27+0100, Marek Vasut wrote:
> On 1/30/19 4:00 PM, Alexandre Belloni wrote:
> > Add a driver for the MicroCrystal RV-3028.
>
> Some additional information in the commit message won't hurt.
>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/rtc/rtc.txt | 1 +
> > drivers/rtc/Kconfig | 9 +
> > drivers/rtc/Makefile | 1 +
> > drivers/rtc/rtc-rv3028.c | 732 ++++++++++++++++++
> > 4 files changed, 743 insertions(+)
> > create mode 100644 drivers/rtc/rtc-rv3028.c
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt
> > index d86e2850fe1c..3e6a215e7304 100644
> > --- a/Documentation/devicetree/bindings/rtc/rtc.txt
> > +++ b/Documentation/devicetree/bindings/rtc/rtc.txt
> > @@ -52,6 +52,7 @@ emmicro,em3027 EM Microelectronic EM3027 Real-time Clock
> > isil,isl1208 Intersil ISL1208 Low Power RTC with Battery Backed SRAM
> > isil,isl1218 Intersil ISL1218 Low Power RTC with Battery Backed SRAM
> > isil,isl12022 Intersil ISL12022 Real-time Clock
> > +microcrystal,rv3028 Real Time Clock Module with I2C-Bus
>
> Shouldn't this be a separate patch ?
>
Not really as this doesn't introduce any new binding and simply
documents a compatible string. Rob is loaded enough to not review that
kind of changes.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-02-12 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 15:00 [PATCH] rtc: rv3028: new driver Alexandre Belloni
2019-01-30 16:13 ` Marek Vasut
2019-02-12 23:21 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212232132.GG10129@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).