From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC8CFC43381 for ; Mon, 25 Mar 2019 17:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 952382087C for ; Mon, 25 Mar 2019 17:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729552AbfCYRE7 (ORCPT ); Mon, 25 Mar 2019 13:04:59 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:44579 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbfCYRE7 (ORCPT ); Mon, 25 Mar 2019 13:04:59 -0400 X-Originating-IP: 109.213.38.144 Received: from localhost (alyon-652-1-47-144.w109-213.abo.wanadoo.fr [109.213.38.144]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1444FE0013; Mon, 25 Mar 2019 17:04:51 +0000 (UTC) Date: Mon, 25 Mar 2019 18:04:51 +0100 From: Alexandre Belloni To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Lee Jones , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Sebastian Reichel , Liam Girdwood , Mark Brown , Alessandro Zummo , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, heikki.haikola@fi.rohmeurope.com, mikko.mutanen@fi.rohmeurope.com Subject: Re: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC Message-ID: <20190325170451.GQ30105@piout.net> References: <901900e12e2a06865b3649ec94af511fcc6443a3.1553515333.git.matti.vaittinen@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <901900e12e2a06865b3649ec94af511fcc6443a3.1553515333.git.matti.vaittinen@fi.rohmeurope.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 25/03/2019 14:06:42+0200, Matti Vaittinen wrote: > Support RTC block in ROHM bd70528 power management IC. Support > getting and setting the time and date as well as arming an alarm > which can also be used to wake the PMIC from standby state. > > HW supports wake interrupt only for the next 24 hours (sec, minute > and hour information only) so we limit also the alarm interrupt to > this 24 hours for the sake of consistency. > > Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni > + r->time.hour |= BD70528_MASK_RTC_HOUR_24H; > + r->day |= bin2bcd(t->tm_mday); > + r->week |= bin2bcd(t->tm_wday); > + r->month |= bin2bcd(t->tm_mon + 1); > + r->year = bin2bcd(t->tm_year-100); If you ever have to resend, please add spaces around that - -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com