From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287F5C43381 for ; Mon, 1 Apr 2019 20:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E578420880 for ; Mon, 1 Apr 2019 20:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbfDAUki (ORCPT ); Mon, 1 Apr 2019 16:40:38 -0400 Received: from muru.com ([72.249.23.125]:43972 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfDAUkh (ORCPT ); Mon, 1 Apr 2019 16:40:37 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BF58180C0; Mon, 1 Apr 2019 20:40:50 +0000 (UTC) Date: Mon, 1 Apr 2019 13:40:33 -0700 From: Tony Lindgren To: Andreas Kemnade Cc: Keerthy , alexandre.belloni@bootlin.com, a.zummo@towertech.it, t-kristo@ti.com, ssantosh@kernel.org, d-gerlach@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Message-ID: <20190401204033.GK49658@atomide.com> References: <20190322171619.4180-1-j-keerthy@ti.com> <20190322171619.4180-4-j-keerthy@ti.com> <20190401175245.GJ49658@atomide.com> <20190401203854.3b6ec1a2@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401203854.3b6ec1a2@kemnade.info> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org * Andreas Kemnade [190401 18:39]: > On Mon, 1 Apr 2019 10:52:45 -0700 > Tony Lindgren wrote: > > > Hi, > > > > * Keerthy [190322 17:16]: > > > +static int am43xx_check_off_mode_enable(void) > > > +{ > > > + /* > > > + * Check for am437x-sk-evm which due to HW design cannot support > > > + * this mode reliably. > > > + */ > > > + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) { > > > + pr_warn("WARNING: This platform does not support off-mode, entering DeepSleep suspend.\n"); > > > + return 0; > > > + } > > > + > > > + return enable_off_mode; > > > +} > > > > Considering off-mode suspend depends on how the board is > > wired for various things such as memory, PMIC and the related > > signal lines, I agree using the machine compatible is the best > > check we can do here. > > > > But since the device can hang during suspend unless things are > > configured right for the board, I suggest you rather list allowed > > boards here that are known to work with off-mode. > > > Could we somehow describe this property of the hardware > (is-offmode-capable or is-wired-for-offmode) as a separate devicetree > property of the soc? > > In mmc we have for example "cap-power-off-card" for > indicating some is-wired-suitable-for thing. And we also have "regulator-off-in-suspend". How about "soc-off-in-suspend" for the generic name? > That looks to be clearer as looking for some strange conditions > derived from something. > > I have still my offmode patch os the boilerplate... Care to send a binding patch to devicetree@vger.kernel.org for that? And then when it gets acked, we can just start using it :) Regards, Tony