From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872B8C4360F for ; Thu, 4 Apr 2019 20:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5ECFB206BA for ; Thu, 4 Apr 2019 20:42:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730155AbfDDUmG (ORCPT ); Thu, 4 Apr 2019 16:42:06 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34365 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729924AbfDDUmG (ORCPT ); Thu, 4 Apr 2019 16:42:06 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 6124D802EB; Thu, 4 Apr 2019 22:41:56 +0200 (CEST) Date: Thu, 4 Apr 2019 22:42:07 +0200 From: Pavel Machek To: Dmitry Torokhov Cc: Nick Crews , Guenter Roeck , Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Alexandre Belloni , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel , Duncan Laurie , Simon Glass Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name Message-ID: <20190404204207.GH29984@amd> References: <20190404185919.GB27340@amd> <20190404191931.GA29984@amd> <20190404200658.GD29984@amd> <20190404202042.GF29984@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TBNym+cBXeFsS4Vs" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org --TBNym+cBXeFsS4Vs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > And what to do if internal keyboard is not platform but USB? Like > > > Google "Whiskers"? (I am not sure why you decided to drop my mention > > > of internal USB keyboards completely off your reply). > > > > I don't have answers for everything. Even if you have USB keyboard, you= 'll > > likely still have backlight connected to embedded controller. If not, > > then maybe you have exception userland needs to know about. > > > > Still better than making everything an exception. >=20 > You do not need to make everything exception. You just need to look > beyond the name, and see how the device is connected. And then apply > your exceptions for "weird" devices. "Where it is connected" is not interesting to the userland. "Is it backlight for internal keyboard" is the right question. It may be connected to embedded controller or some kind of controller over i2c... my shell scripts should not need to know about architecture of every notebook out there. But I don't see why I should do additional work when its trivial for kernel to just name the LED in an useful way. "platform::kbd_backlight" has no disadvantages compared to "wilco::kbd_backlight" ... so lets just use it. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --TBNym+cBXeFsS4Vs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlymbB8ACgkQMOfwapXb+vJJYwCfX5l28e2wBm03LKaV/yWkOhJj 6jIAoI8ECdVuduZ5jO34B8p1MsEbK8ja =6gux -----END PGP SIGNATURE----- --TBNym+cBXeFsS4Vs--