From: Thierry Reding <thierry.reding@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] rtc: tegra: set range
Date: Mon, 8 Apr 2019 12:22:49 +0200 [thread overview]
Message-ID: <20190408102249.GC6644@ulmo> (raw)
In-Reply-To: <20190407211646.14962-1-alexandre.belloni@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Sun, Apr 07, 2019 at 11:16:44PM +0200, Alexandre Belloni wrote:
> The Tegra 20 RTC is a 32bit seconds counter (with an unused millisecond
> counter).
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-tegra.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
> index c6b0a99aa3a9..3f93a1f7abb5 100644
> --- a/drivers/rtc/rtc-tegra.c
> +++ b/drivers/rtc/rtc-tegra.c
> @@ -306,6 +306,13 @@ static int __init tegra_rtc_probe(struct platform_device *pdev)
>
> info->tegra_rtc_irq = ret;
>
> + info->rtc_dev = devm_rtc_allocate_device(&pdev->dev);
> + if (IS_ERR(info->rtc_dev))
> + return PTR_ERR(info->rtc_dev);
> +
> + info->rtc_dev->ops = &tegra_rtc_ops;
> + info->rtc_dev->range_max = U32_MAX;
The placement of this new block seems somewhat arbitrary, but either
way:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-08 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 21:16 [PATCH 1/3] rtc: tegra: set range Alexandre Belloni
2019-04-07 21:16 ` [PATCH 2/3] rtc: tegra: switch to rtc_time64_to_tm/rtc_tm_to_time64 Alexandre Belloni
2019-04-08 10:23 ` Thierry Reding
2019-04-07 21:16 ` [PATCH 3/3] rtc: tegra: convert to SPDX identifier Alexandre Belloni
2019-04-08 10:23 ` Thierry Reding
2019-04-08 10:22 ` Thierry Reding [this message]
2019-04-08 11:54 ` [PATCH 1/3] rtc: tegra: set range Alexandre Belloni
2019-04-08 12:57 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408102249.GC6644@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).