From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92290C0651F for ; Thu, 4 Jul 2019 18:55:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F519218A0 for ; Thu, 4 Jul 2019 18:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbfGDSy7 (ORCPT ); Thu, 4 Jul 2019 14:54:59 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41479 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727017AbfGDSy7 (ORCPT ); Thu, 4 Jul 2019 14:54:59 -0400 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 565C21C0009; Thu, 4 Jul 2019 18:54:48 +0000 (UTC) Date: Thu, 4 Jul 2019 20:54:48 +0200 From: Alexandre Belloni To: Frank Wunderlich Cc: Lee Jones , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , Sebastian Reichel , Alessandro Zummo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, Eddie Huang , Thomas Gleixner , Richard Fontana , Allison Randal , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Rob Herring , Linus Walleij , Nicolas Ferre , "Paul E . McKenney" , Josef Friedl Subject: Re: [PATCH v2 1/7] docs: dt-bindings: add poweroff Message-ID: <20190704185448.GI3692@piout.net> References: <20190703164822.17924-1-frank-w@public-files.de> <20190703164822.17924-2-frank-w@public-files.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703164822.17924-2-frank-w@public-files.de> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Please use a better subject line. On 03/07/2019 18:48:16+0200, Frank Wunderlich wrote: > From: Josef Friedl > > add documentation for pmic, rtc and power/reset devicetree bindings > > Suggested-by: Frank Wunderlich > Signed-off-by: Josef Friedl > Signed-off-by: Frank Wunderlich > --- > .../devicetree/bindings/mfd/mt6397.txt | 10 ++++++- > .../bindings/power/reset/mt6323-poweroff.txt | 20 +++++++++++++ > .../devicetree/bindings/rtc/rtc-mt6397.txt | 29 +++++++++++++++++++ This file is unrelated to the patch, it should be separated. > 3 files changed, 58 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt > create mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt6397.txt > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 0ebd08af777d..44acb9827716 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -8,6 +8,7 @@ MT6397/MT6323 is a multifunction device with the following sub modules: > - Clock > - LED > - Keys > +- Power controller > > It is interfaced to host controller using SPI interface by a proprietary hardware > called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. > @@ -22,8 +23,10 @@ compatible: "mediatek,mt6397" or "mediatek,mt6323" > Optional subnodes: > > - rtc > - Required properties: > + Required properties: Should be one of follows > + - compatible: "mediatek,mt6323-rtc" > - compatible: "mediatek,mt6397-rtc" > + For details, see Documentation/devicetree/bindings/rtc/rtc-mt6397.txt > - regulators > Required properties: > - compatible: "mediatek,mt6397-regulator" > @@ -46,6 +49,11 @@ Optional subnodes: > - compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys" > see Documentation/devicetree/bindings/input/mtk-pmic-keys.txt > > +- power-controller > + Required properties: > + - compatible: "mediatek,mt6323-pwrc" > + For details, see Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt > + > Example: > pwrap: pwrap@1000f000 { > compatible = "mediatek,mt8135-pwrap"; > diff --git a/Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt b/Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt > new file mode 100644 > index 000000000000..933f0c48e887 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt > @@ -0,0 +1,20 @@ > +Device Tree Bindings for Power Controller on MediaTek PMIC > + > +The power controller which could be found on PMIC is responsible for externally > +powering off or on the remote MediaTek SoC through the circuit BBPU. > + > +Required properties: > +- compatible: Should be one of follows > + "mediatek,mt6323-pwrc": for MT6323 PMIC > + > +Example: > + > + pmic { > + compatible = "mediatek,mt6323"; > + > + ... > + > + power-controller { > + compatible = "mediatek,mt6323-pwrc"; > + }; > + } > diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt > new file mode 100644 > index 000000000000..ebd1cf80dcc8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt > @@ -0,0 +1,29 @@ > +Device-Tree bindings for MediaTek PMIC based RTC > + > +MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works > +as a type of multi-function device (MFD). The RTC can be configured and set up > +with PMIC wrapper bus which is a common resource shared with the other > +functions found on the same PMIC. > + > +For MediaTek PMIC MFD bindings, see: > +Documentation/devicetree/bindings/mfd/mt6397.txt > + > +For MediaTek PMIC wrapper bus bindings, see: > +Documentation/devicetree/bindings/soc/mediatek/pwrap.txt > + > +Required properties: > +- compatible: Should be one of follows > + "mediatek,mt6323-rtc": for MT6323 PMIC > + "mediatek,mt6397-rtc": for MT6397 PMIC > + > +Example: > + > + pmic { > + compatible = "mediatek,mt6323"; > + > + ... > + > + rtc { > + compatible = "mediatek,mt6323-rtc"; > + }; > + }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com