From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092E0C48BD5 for ; Sat, 6 Jul 2019 20:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1C272083B for ; Sat, 6 Jul 2019 20:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbfGFUEa (ORCPT ); Sat, 6 Jul 2019 16:04:30 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40343 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfGFUEa (ORCPT ); Sat, 6 Jul 2019 16:04:30 -0400 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4B50AE0003; Sat, 6 Jul 2019 20:04:20 +0000 (UTC) Date: Sat, 6 Jul 2019 22:04:20 +0200 From: Alexandre Belloni To: Frank Wunderlich Cc: Lee Jones , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , Sebastian Reichel , Alessandro Zummo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, Eddie Huang , Thomas Gleixner , Richard Fontana , Allison Randal , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Rob Herring , Linus Walleij , Nicolas Ferre , "Paul E . McKenney" , Josef Friedl Subject: Re: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver Message-ID: <20190706200420.GE12409@piout.net> References: <20190703164822.17924-1-frank-w@public-files.de> <20190703164822.17924-4-frank-w@public-files.de> <20190704204336.GJ3692@piout.net> <20190705212448.GB12409@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 06/07/2019 18:15:20+0200, Frank Wunderlich wrote: > > Gesendet: Freitag, 05. Juli 2019 um 23:24 Uhr > > Von: "Alexandre Belloni" > > > Let's say the RTC has been used to start your platform, then the irq > > handler will be called as soon as the irq is requested, leading to a > > null pointer dereference. > > i cannot test this with my platform, but i have changed it in my repo > > https://github.com/frank-w/BPI-R2-4.14/commits/5.2-poweroff-mainline > > > Yes and IIRC, I did comment that the rtc change also had to be separated > > from 1/7. > > also this is put in separate commit, can you take a look before i post v3? > > > Also, I really doubt this new compatible is necessary at all as you > > could simply directly use mediatek,mt6397-rtc. > > imho this can confuse because the wrong chip-name is used in dts > This is not true, we do that all the time and the immediate benefit of using the mt6397 compatible is that then there is no need to synchronize between subsystems. If you want to be absolutely conservative, you could use compatible = "mediatek,mt6323-rtc", "mediatek,mt6397-rtc"; in your DT. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com