From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0875FC31E40 for ; Sat, 13 Jul 2019 19:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2D3920848 for ; Sat, 13 Jul 2019 19:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbfGMTby (ORCPT ); Sat, 13 Jul 2019 15:31:54 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56793 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727936AbfGMTby (ORCPT ); Sat, 13 Jul 2019 15:31:54 -0400 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C15A460004; Sat, 13 Jul 2019 19:31:51 +0000 (UTC) Date: Sat, 13 Jul 2019 21:31:51 +0200 From: Alexandre Belloni To: YueHaibing Cc: a.zummo@towertech.it, Dylan.Howey@tennantco.com, ravi23ganiga@gmail.com, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH] rtc: pcf2123: Fix build error Message-ID: <20190713193151.GA4732@piout.net> References: <20190704085542.48180-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190704085542.48180-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 04/07/2019 16:55:42+0800, YueHaibing wrote: > If REGMAP_SPI is m and RTC_DRV_PCF2123 is y, > > drivers/rtc/rtc-pcf2123.o: In function `pcf2123_probe': > rtc-pcf2123.c:(.text+0xb2b): undefined reference to `__devm_regmap_init_spi' > > Select REGMAP_SPI as RTC_DRV_DS1347 driver does. > > Reported-by: Hulk Robot > Fixes: 790d033933b8 ("rtc: pcf2123: port to regmap") > Signed-off-by: YueHaibing > --- > drivers/rtc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com