From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tbm@cyrius.com, Oliver Hartkopp <socketcan@hartkopp.net>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
Date: Wed, 24 Jul 2019 10:57:53 +0200 [thread overview]
Message-ID: <20190724085753.GP24911@piout.net> (raw)
In-Reply-To: <04efe868-ffaf-8b50-f52f-ce86aa2f3a38@kleine-koenig.org>
On 23/07/2019 22:24:18+0200, Uwe Kleine-König wrote:
> On 7/23/19 10:03 PM, Alexandre Belloni wrote:
> > On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote:
> >> The internal RTC doesn't work, loading the driver only yields
> >>
> >> rtc-mv f1010300.rtc: internal RTC not ticking
> >>
> >> . So disable it.
> >>
> >> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> >> ---
> >> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> >> index a88eb22070a1..994cabcf4b51 100644
> >> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> >> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> >> @@ -104,3 +104,11 @@
> >> &pcie0 {
> >> status = "okay";
> >> };
> >> +
> >> +&rtc {
> >> + /*
> >> + * There is a s35390a available on the i2c bus, the internal rtc isn't
> >> + * working (probably no crystal assembled).
> >> + */
> >> + status = "disabled";
> >> +};
> >
> > You could also use the aliases to ensure rtc0 is the s35390a. This would
> > solve the initial issue.
>
> What do you assume is my initial issue? Adding the alias doesn't make
> the above message disappear from the boot log.
>
I overlooked that the rtc is not working at all (and I thought it only
needed some init in u-boot like the armada38x). Seems good to me then.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-07-24 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 19:45 [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-07-23 20:03 ` Alexandre Belloni
2019-07-23 20:24 ` Uwe Kleine-König
2019-07-24 8:57 ` Alexandre Belloni [this message]
2019-07-23 22:20 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724085753.GP24911@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=tbm@cyrius.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).