From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C6E0C4360C for ; Fri, 4 Oct 2019 15:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B7FA2084D for ; Fri, 4 Oct 2019 15:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570201519; bh=PY00z/yQLvdHY3HuHe8b++knUuCmduzQH84HBTF1sBc=; h=From:To:Cc:Subject:Date:List-ID:From; b=1eHUN8BJ7AOgga4kzVqZCJzL3V49W6L2wkpzCeGsKewRPktIK+J4YRtCoH8XvJjg8 MF9JwEURXmHLgo9DsORxnDEuLsOnNcyegNdYae+hhzEFMZKtdav5xYTLk8w8HTzNhZ /dJ3/rqv/mQ5ezoXyhmET6L6DWyHlgfdc3vFI1dA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388870AbfJDPFT (ORCPT ); Fri, 4 Oct 2019 11:05:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:49662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388802AbfJDPFS (ORCPT ); Fri, 4 Oct 2019 11:05:18 -0400 Received: from localhost.localdomain (unknown [194.230.155.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4232A2133F; Fri, 4 Oct 2019 15:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570201518; bh=PY00z/yQLvdHY3HuHe8b++knUuCmduzQH84HBTF1sBc=; h=From:To:Cc:Subject:Date:From; b=VKsZHLOovHV5rTTC5N1+XY2+t0yT6eGKvbZh60P63Es0abcv7MFIV9ltQIBY0Kwlc 5AWwpRKUmIJ5rTH3gMgY7bbPi4HN5Mz6mxAXqK8jdRXDrjk3Zj4pjv2qKw8tXEtT5E GGiGm4RTVRJ07vs8O3yktxzqNX9e0fpK6BdR8Ce4= From: Krzysztof Kozlowski To: Support Opensource , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT] rtc: da9063: Handle invalid IRQ from platform_get_irq_byname() Date: Fri, 4 Oct 2019 17:05:10 +0200 Message-Id: <20191004150510.6278-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org platform_get_irq_byname() might return -errno which later would be cast to an unsigned int and used in request_irq(). Signed-off-by: Krzysztof Kozlowski --- Not marking as cc-stable as this was not reproduced and not tested. --- drivers/rtc/rtc-da9063.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c index 15908d51b1cb..046b1d4c3dae 100644 --- a/drivers/rtc/rtc-da9063.c +++ b/drivers/rtc/rtc-da9063.c @@ -483,6 +483,9 @@ static int da9063_rtc_probe(struct platform_device *pdev) rtc->rtc_dev->uie_unsupported = 1; irq_alarm = platform_get_irq_byname(pdev, "ALARM"); + if (irq_alarm < 0) + return irq_alarm; + ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL, da9063_alarm_event, IRQF_TRIGGER_LOW | IRQF_ONESHOT, -- 2.17.1