From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F69C4360C for ; Wed, 16 Oct 2019 08:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92ABA21848 for ; Wed, 16 Oct 2019 08:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391656AbfJPIkV (ORCPT ); Wed, 16 Oct 2019 04:40:21 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56295 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389897AbfJPIkV (ORCPT ); Wed, 16 Oct 2019 04:40:21 -0400 X-Originating-IP: 86.207.98.53 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id F1DF9E000C; Wed, 16 Oct 2019 08:40:17 +0000 (UTC) Date: Wed, 16 Oct 2019 10:40:17 +0200 From: Alexandre Belloni To: Thomas Bogendoerfer Cc: Ralf Baechle , Paul Burton , James Hogan , Joshua Kinard , Alessandro Zummo , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2] rtc: ds1685: add indirect access method and remove plat_read/plat_write Message-ID: <20191016084017.GZ3125@piout.net> References: <20191014214621.25257-1-tbogendoerfer@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014214621.25257-1-tbogendoerfer@suse.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 14/10/2019 23:46:21+0200, Thomas Bogendoerfer wrote: > SGI Octane (IP30) doesn't have RTC register directly mapped into CPU > address space, but accesses RTC registers with an address and data > register. This is now supported by additional access functions, which > are selected by a new field in platform data. Removed plat_read/plat_write > since there is no user and their usage could introduce lifetime issue, > when functions are placed in different modules. > > Signed-off-by: Thomas Bogendoerfer > --- > Changes in v2: > > - check if rtc->read and rtc->write are setup > - spell out indirect in function names and explain difference > between standard and indirect functions > > arch/mips/sgi-ip32/ip32-platform.c | 2 +- > drivers/rtc/rtc-ds1685.c | 78 +++++++++++++++++++++++++------------- > include/linux/rtc/ds1685.h | 8 ++-- > 3 files changed, 58 insertions(+), 30 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com