From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644C0CA9EB9 for ; Wed, 23 Oct 2019 23:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3130220679 for ; Wed, 23 Oct 2019 23:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408017AbfJWXUI (ORCPT ); Wed, 23 Oct 2019 19:20:08 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:58441 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404151AbfJWXUH (ORCPT ); Wed, 23 Oct 2019 19:20:07 -0400 X-Originating-IP: 86.202.229.42 Received: from localhost (lfbn-lyo-1-146-42.w86-202.abo.wanadoo.fr [86.202.229.42]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9E9D81C0002; Wed, 23 Oct 2019 23:20:04 +0000 (UTC) Date: Thu, 24 Oct 2019 01:20:04 +0200 From: Alexandre Belloni To: "Luck, Tony" Cc: Arnd Bergmann , Greg Kroah-Hartman , "linux-rtc@vger.kernel.org" , Alessandro Zummo , "linux-ia64@vger.kernel.org" , "Yu, Fenghua" , Stephane Eranian , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver Message-ID: <20191023232004.GV3125@piout.net> References: <20191023150311.844123-1-arnd@arndb.de> <20191023184616.GA17078@agluck-desk2.amr.corp.intel.com> <20191023200135.GT3125@piout.net> <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 23/10/2019 21:30:29+0000, Luck, Tony wrote: > >> rtc-efi rtc-efi: setting system clock to 2019-10-23T18:30:23 UTC (1571855423) > > > You can remove CONFIG_RTC_HCTOSYS, this line will disappear, systemd > > will not like that but efirtc was not setting the system time anyway so > > this shouldn't change the behaviour. > > > Wait ... that message says "setting system clock" > > but then you say " efirtc was not setting the system time anyway". > > So did the time get set, or not? > > If it wasn't set, why does the message say that it was set? > What I meant was that drivers/char/efirtc.c was not setting the system time but when using drivers/rtc/rtc-efi.c with CONFIG_RTC_HCTOSYS, the kernel will use the rtc to set the system time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com