From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Bastian Krause <bst@pengutronix.de>
Cc: Marek Vasut <marex@denx.de>,
linux-rtc@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
kernel@pengutronix.de
Subject: Re: [PATCH V2] rtc: ds1307: Enable battery backup on RX8130
Date: Thu, 21 Nov 2019 17:39:41 +0100 [thread overview]
Message-ID: <20191121161303.GD299836@piout.net> (raw)
In-Reply-To: <55288b3f-64e6-7ddb-3bcb-3418c976c59c@pengutronix.de>
On 21/11/2019 09:21:49+0100, Bastian Krause wrote:
>
> On 11/21/19 9:14 AM, Marek Vasut wrote:
> > On 11/21/19 9:09 AM, Bastian Krause wrote:
> >> On 9/5/19 3:03 PM, Marek Vasut wrote:
> >>> The battery backup can be disabled on this RTC, e.g. if populated right
> >>> out of production. Force the battery backup bit on to enable it.
> >>>
> >>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>> Cc: Arnaud Ebalard <arno@natisbad.org>
> >>> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >>> Cc: Bastian Krause <bst@pengutronix.de>
> >>
> >> Reviewed-by: Bastian Krause <bst@pengutronix.de>
> >>
> >
> > I recall there was some comment about setting BIT(5) as well,
> > RX8130_REG_CONTROL1_CHGEN , can you check that ?
>
> RX8130_REG_CONTROL1_CHGEN decides whether the battery or the supercap
> should be charged or not. I think this patch is okay as is. I'll send a
> follow-up patch which will set RX8130_REG_CONTROL1_CHGEN depending on a
> new dt-binding "epson,backup-battery-chargeable" once this one is applied.
>
You need to have a generic RTC property, either reuse
trickle-diode-disable (I know the name is a bit unfortunate but that is
waht we have) or have a new property stating that the auxiliary voltage
is chargeable. using battery in the name is probably not wise because
this may as well be a supercap.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-21 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 13:03 [PATCH V2] rtc: ds1307: Enable battery backup on RX8130 Marek Vasut
2019-11-21 8:09 ` Bastian Krause
2019-11-21 8:14 ` Marek Vasut
2019-11-21 8:21 ` Bastian Krause
2019-11-21 8:28 ` Marek Vasut
2019-11-21 16:39 ` Alexandre Belloni [this message]
2019-11-22 9:48 ` Bastian Krause
2019-12-16 11:17 ` Bastian Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121161303.GD299836@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=arno@natisbad.org \
--cc=bst@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).