Re: [PATCH][V2][next] rtc: ds1307: check for failed memory allocation on wdt

Alexandre Belloni
2020-04-03T09:22:54Z

On 03/04/2020 11:45:04+0300, Dan Carpenter wrote:
> On Thu, Apr 02, 2020 at 04:53:12PM +0200, Alexandre Belloni wrote:
> >
> > As stated, I also prefer keeping the watchdog optional and ignore the
> > error.
>
> Hopefully you aren't running out of memory on start up. In current
> kernels small memory allocations like this never fail so it doesn't
> really affect runtime. It only silences the NULL dereference static
> checker warning.
>

Yes, so the

if (!wdt)
return;

would be enough instead of introducing unnecessary error handling.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering