From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: liambeguin@gmail.com
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 3/3] rtc: pcf2127: reset alarm interrupt at power on
Date: Tue, 9 Jun 2020 23:07:39 +0200 [thread overview]
Message-ID: <20200609210739.GV3720@piout.net> (raw)
In-Reply-To: <20200607170610.24534-4-liambeguin@gmail.com>
On 07/06/2020 13:06:10-0400, liambeguin@gmail.com wrote:
> From: Liam Beguin <lvb@xiphos.com>
>
> From: Liam Beguin <lvb@xiphos.com>
Always include a commit message.
>
> Signed-off-by: Liam Beguin <lvb@xiphos.com>
> ---
> drivers/rtc/rtc-pcf2127.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
> index 3eeb085a7c72..f004a4030970 100644
> --- a/drivers/rtc/rtc-pcf2127.c
> +++ b/drivers/rtc/rtc-pcf2127.c
> @@ -546,6 +546,14 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
>
> pcf2127->rtc->ops = &pcf2127_rtc_ops;
>
> + ret = regmap_update_bits(pcf2127->regmap, PCF2127_REG_CTRL2,
> + PCF2127_BIT_CTRL2_AIE, 0);
> + if (ret) {
> + dev_err(dev, "%s: failed to clear interrupt enable bit (%d)",
> + __func__, ret);
> + return ret;
> + }
> +
The driver simply must not do that or alarms will be missed.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-06-09 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 17:06 [PATCH 0/3] rtc: pcf2127: add alarm support liambeguin
2020-06-07 17:06 ` [PATCH 1/3] rtc: pcf2127: add pca2129 device id liambeguin
2020-06-09 20:48 ` Bruno Thomsen
2020-06-07 17:06 ` [PATCH 2/3] rtc: pcf2127: add alarm support liambeguin
2020-06-09 20:42 ` Bruno Thomsen
2020-06-10 15:38 ` Liam Beguin
2020-06-09 21:05 ` Alexandre Belloni
2020-06-10 15:49 ` Liam Beguin
2020-06-10 16:32 ` Alexandre Belloni
2020-06-07 17:06 ` [PATCH 3/3] rtc: pcf2127: reset alarm interrupt at power on liambeguin
2020-06-09 21:07 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609210739.GV3720@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=liambeguin@gmail.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).