From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DE2C433E0 for ; Tue, 16 Jun 2020 18:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A1E92078D for ; Tue, 16 Jun 2020 18:31:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728014AbgFPSbb (ORCPT ); Tue, 16 Jun 2020 14:31:31 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:57869 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727114AbgFPSba (ORCPT ); Tue, 16 Jun 2020 14:31:30 -0400 X-Originating-IP: 86.202.110.81 Received: from localhost (lfbn-lyo-1-15-81.w86-202.abo.wanadoo.fr [86.202.110.81]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AF3F6C0002; Tue, 16 Jun 2020 18:31:28 +0000 (UTC) Date: Tue, 16 Jun 2020 20:31:28 +0200 From: Alexandre Belloni To: Liam Beguin Cc: bruno.thomsen@gmail.com, a.zummo@towertech.it, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 2/2] rtc: pcf2127: add alarm support Message-ID: <20200616183128.GI241261@piout.net> References: <20200616090254.GH241261@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 16/06/2020 09:07:59-0400, Liam Beguin wrote: > > It is generally not useful to have those debug strings anymore because > > the core already provides tracepoints at the correct locations. > > > > If you really want to keep it, then please use %ptR. > > > > This is also valid for the other dev_dbg. > > > > I'm not particularly attached to keeping these in. I just left them in > since it seemed to be common in other rtc drivers. > Yes, those predates the tracepoints (which are fairly recent). -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com