From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v2 00/11] rtc: rx8010: use regmap instead of i2c smbus API
Date: Thu, 10 Sep 2020 15:04:35 +0200 [thread overview]
Message-ID: <20200910130446.5689-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
I want to use this driver on a platform where the i2c controller doesn't
speak SMBUS. This series converts the driver to i2c regmap which can
figure out the correct protocol to use.
The actual conversion happens in patch 10, the rest are just cleanups and
refactoring.
v1 -> v2:
- s/parentheses/brackets/g
- add a patch switching the driver to using the preferred RTC API
- rework the patch removing magic values
- use range_max and range_min instead of manual range checks
- add a patch adding a helper variable in probe() for client->dev
- add a patch using sizeof(*rx8010) instead of sizeof(struct rx8010_data)
--
Alexandre: I believe that the implementation of devm_rtc_allocate_device()
and rtc_register_device() is wrong as I explained under the previous
version of this series. I'll send an RFC that reworks this part soon.
Bartosz Golaszewski (11):
rtc: rx8010: remove unnecessary brackets
rtc: rx8010: consolidate local variables of the same type
rtc: rx8010: use tabs instead of spaces for code formatting
rtc: rx8010: rename ret to err in rx8010_set_time()
rtc: rx8010: don't use magic values for time buffer length
rtc: rx8010: drop unnecessary initialization
rtc: rx8010: use a helper variable for client->dev in probe()
rtc: rx8010: prefer sizeof(*val) over sizeof(struct type_of_val)
rtc: rx8010: switch to using the preferred RTC API
rtc: rx8010: convert to using regmap
rtc: rx8010: use range checking provided by core RTC code
drivers/rtc/rtc-rx8010.c | 306 +++++++++++++++++----------------------
1 file changed, 131 insertions(+), 175 deletions(-)
--
2.26.1
next reply other threads:[~2020-09-10 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:04 Bartosz Golaszewski [this message]
2020-09-10 13:04 ` [PATCH v2 01/11] rtc: rx8010: remove unnecessary brackets Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 02/11] rtc: rx8010: consolidate local variables of the same type Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 03/11] rtc: rx8010: use tabs instead of spaces for code formatting Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 04/11] rtc: rx8010: rename ret to err in rx8010_set_time() Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 05/11] rtc: rx8010: don't use magic values for time buffer length Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 06/11] rtc: rx8010: drop unnecessary initialization Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 07/11] rtc: rx8010: use a helper variable for client->dev in probe() Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 08/11] rtc: rx8010: prefer sizeof(*val) over sizeof(struct type_of_val) Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 09/11] rtc: rx8010: switch to using the preferred RTC API Bartosz Golaszewski
2020-09-11 12:33 ` Alexandre Belloni
2020-09-10 13:04 ` [PATCH v2 10/11] rtc: rx8010: convert to using regmap Bartosz Golaszewski
2020-09-10 13:04 ` [PATCH v2 11/11] rtc: rx8010: use range checking provided by core RTC code Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910130446.5689-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).