* [PATCH] rtc: mxc: Remove unused .id_table support
@ 2020-11-16 15:43 Fabio Estevam
2020-11-16 17:26 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2020-11-16 15:43 UTC (permalink / raw)
To: alexandre.belloni; +Cc: linux-rtc, Fabio Estevam
Since 5.10-rc1 i.MX is a devicetree-only platform and the existing
.id_table support in this driver was only useful for old non-devicetree
platforms.
Get rid of the .id_table since it is no longer used.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/rtc/rtc-mxc.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
index a8cfbde048f4..78d7fba00895 100644
--- a/drivers/rtc/rtc-mxc.c
+++ b/drivers/rtc/rtc-mxc.c
@@ -70,19 +70,6 @@ struct rtc_plat_data {
enum imx_rtc_type devtype;
};
-static const struct platform_device_id imx_rtc_devtype[] = {
- {
- .name = "imx1-rtc",
- .driver_data = IMX1_RTC,
- }, {
- .name = "imx21-rtc",
- .driver_data = IMX21_RTC,
- }, {
- /* sentinel */
- }
-};
-MODULE_DEVICE_TABLE(platform, imx_rtc_devtype);
-
#ifdef CONFIG_OF
static const struct of_device_id imx_rtc_dt_ids[] = {
{ .compatible = "fsl,imx1-rtc", .data = (const void *)IMX1_RTC },
@@ -438,7 +425,6 @@ static struct platform_driver mxc_rtc_driver = {
.name = "mxc_rtc",
.of_match_table = of_match_ptr(imx_rtc_dt_ids),
},
- .id_table = imx_rtc_devtype,
.probe = mxc_rtc_probe,
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: mxc: Remove unused .id_table support
2020-11-16 15:43 [PATCH] rtc: mxc: Remove unused .id_table support Fabio Estevam
@ 2020-11-16 17:26 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-11-16 17:26 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-rtc
Hello,
On 16/11/2020 12:43:03-0300, Fabio Estevam wrote:
> Since 5.10-rc1 i.MX is a devicetree-only platform and the existing
> .id_table support in this driver was only useful for old non-devicetree
> platforms.
>
> Get rid of the .id_table since it is no longer used.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/rtc/rtc-mxc.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
> index a8cfbde048f4..78d7fba00895 100644
> --- a/drivers/rtc/rtc-mxc.c
> +++ b/drivers/rtc/rtc-mxc.c
> @@ -70,19 +70,6 @@ struct rtc_plat_data {
> enum imx_rtc_type devtype;
> };
>
> -static const struct platform_device_id imx_rtc_devtype[] = {
> - {
> - .name = "imx1-rtc",
> - .driver_data = IMX1_RTC,
> - }, {
> - .name = "imx21-rtc",
> - .driver_data = IMX21_RTC,
> - }, {
> - /* sentinel */
> - }
> -};
> -MODULE_DEVICE_TABLE(platform, imx_rtc_devtype);
> -
> #ifdef CONFIG_OF
Is this #ifdef still necessary?
> static const struct of_device_id imx_rtc_dt_ids[] = {
> { .compatible = "fsl,imx1-rtc", .data = (const void *)IMX1_RTC },
> @@ -438,7 +425,6 @@ static struct platform_driver mxc_rtc_driver = {
> .name = "mxc_rtc",
> .of_match_table = of_match_ptr(imx_rtc_dt_ids),
> },
> - .id_table = imx_rtc_devtype,
> .probe = mxc_rtc_probe,
> };
>
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 15:43 [PATCH] rtc: mxc: Remove unused .id_table support Fabio Estevam
2020-11-16 17:26 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).