From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F7AC63798 for ; Fri, 27 Nov 2020 13:22:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DCD22224D for ; Fri, 27 Nov 2020 13:22:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qIbq5vaB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730506AbgK0NWe (ORCPT ); Fri, 27 Nov 2020 08:22:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730343AbgK0NWd (ORCPT ); Fri, 27 Nov 2020 08:22:33 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAFCC0613D1 for ; Fri, 27 Nov 2020 05:22:32 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id f190so3500305wme.1 for ; Fri, 27 Nov 2020 05:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oX0bOkw7GMihlFDHpc3hUl4NHpH/S5J1UA5FeTz+LA8=; b=qIbq5vaBUR8UzcGOv6ZHj/GueHfwo63BjNzFQYSNNQufIWW7NVMqZf2QpJh89Jh3AV MFWr8ToZx6SF3YXYRM9AdcoLleBGPlqux/pmGoz7lhXjuyjqmULnhLQKilnxXvbIG4Sr H5kgQkLPVdVPKruTG6xRAbqZ20IuoLidlVJWxV0tNt6br/1mNxTvzTbat0uiLUA8TSjX LeU5p6zFTPqNrey4ctH9Le+2dCxy1JkEAeHEHkCV9Gh3omzOp9fe7fG5gE64YKBuYHw7 0q/YvltmcuNtdgtN8XGDUmcmitCSLUJATUWXsHCX/8E2KFdNv8KjM6s/F1CVIgdmHlSM yPDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oX0bOkw7GMihlFDHpc3hUl4NHpH/S5J1UA5FeTz+LA8=; b=KQq1nSu7I0U/uxT9mf0kKRRV9gyfZmRzVvYtZR591sz3E94x5UiIOxlQxoXv+tqLZ6 1dHQyyGfZab4CWKgBisnVGgmmdyz9UEkiOP+9N4K2Q4LHwQOZIlPCVQ9r1f6LzVb1Ou0 InbNxL6j7mDpI4GnePdAz+J6kljgvjgGmcwIHNdtsIdCu1Q8dwxb5GmVaVSTapu4kUl3 EjE7ZGenyeUd0DxEcaPq10gxqaMyI7yr3Kdlm+CYgWxJN/QSaYZrv51BJB7mVBeXlIpM 06HD3Xs2weU9rJgES5v7HSraI5sqU/5pl+2Hy2IuLq4i47euIEygs4Z+A+Vadvo71bnA 5DlA== X-Gm-Message-State: AOAM532Bc8+r8PtvShQGBe8e+LN92/evmELuook7FwiOcJWnKo4gs248 kupgeJcgnydPbzIWVjd3AshRVA== X-Google-Smtp-Source: ABdhPJwbrXmgAUkkKu5kwC3hwFFP4pSk0YVly8kwcQFJUUxfEEFcnhGLIZd7qEZzqDzy6MZpVwjENA== X-Received: by 2002:a1c:b107:: with SMTP id a7mr8789408wmf.121.1606483351047; Fri, 27 Nov 2020 05:22:31 -0800 (PST) Received: from dell ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id j13sm7837713wrp.70.2020.11.27.05.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 05:22:30 -0800 (PST) Date: Fri, 27 Nov 2020 13:22:28 +0000 From: Lee Jones To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 7/8] rtc: rework rtc_register_device() resource management Message-ID: <20201127132228.GV2455276@dell> References: <20201109163409.24301-1-brgl@bgdev.pl> <20201109163409.24301-8-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Fri, 27 Nov 2020, Bartosz Golaszewski wrote: > On Fri, Nov 27, 2020 at 10:16 AM Lee Jones wrote: > > > > > > > > On Mon, 9 Nov 2020 at 16:34, Bartosz Golaszewski wrote: > >> > >> From: Bartosz Golaszewski > >> > >> rtc_register_device() is a managed interface but it doesn't use devres > >> by itself - instead it marks an rtc_device as "registered" and the devres > >> callback for devm_rtc_allocate_device() takes care of resource release. > >> > >> This doesn't correspond with the design behind devres where managed > >> structures should not be aware of being managed. The correct solution > >> here is to register a separate devres callback for unregistering the > >> device. > >> > >> While at it: rename rtc_register_device() to devm_rtc_register_device() > >> and add it to the list of managed interfaces in devres.rst. This way we > >> can avoid any potential confusion of driver developers who may expect > >> there to exist a corresponding unregister function. > >> > >> Signed-off-by: Bartosz Golaszewski > >> --- > >> .../driver-api/driver-model/devres.rst | 1 + > >> arch/alpha/kernel/rtc.c | 2 +- > >> drivers/mfd/menelaus.c | 2 +- > > > > > > This patch should have been sent to and Acked by MFD too. > > > > Sorry Lee, I missed the fact that there were changes outside of > drivers/rtc/. Other than skipping the MFD maintainer - do you see > anything wrong in that bit? No real harm done. The patch looks fine from an MFD standpoint. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog