From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/12] rtc: rx8025: use rtc_add_group
Date: Sun, 7 Nov 2021 23:54:56 +0100 [thread overview]
Message-ID: <20211107225458.111068-11-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20211107225458.111068-1-alexandre.belloni@bootlin.com>
Remove open coded sysfs registration by using rtc_add_group.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-rx8025.c | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
index fcfdefe94a7c..c5b3814f8c8e 100644
--- a/drivers/rtc/rtc-rx8025.c
+++ b/drivers/rtc/rtc-rx8025.c
@@ -502,15 +502,14 @@ static DEVICE_ATTR(clock_adjust_ppb, S_IRUGO | S_IWUSR,
rx8025_sysfs_show_clock_adjust,
rx8025_sysfs_store_clock_adjust);
-static int rx8025_sysfs_register(struct device *dev)
-{
- return device_create_file(dev, &dev_attr_clock_adjust_ppb);
-}
+static struct attribute *rx8025_attrs[] = {
+ &dev_attr_clock_adjust_ppb.attr,
+ NULL
+};
-static void rx8025_sysfs_unregister(struct device *dev)
-{
- device_remove_file(dev, &dev_attr_clock_adjust_ppb);
-}
+static const struct attribute_group rx8025_attr_group = {
+ .attrs = rx8025_attrs,
+};
static int rx8025_probe(struct i2c_client *client,
const struct i2c_device_id *id)
@@ -562,18 +561,11 @@ static int rx8025_probe(struct i2c_client *client,
set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rx8025->rtc->features);
clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rx8025->rtc->features);
- err = devm_rtc_register_device(rx8025->rtc);
+ err = rtc_add_group(rx8025->rtc, &rx8025_attr_group);
if (err)
return err;
- err = rx8025_sysfs_register(&client->dev);
- return err;
-}
-
-static int rx8025_remove(struct i2c_client *client)
-{
- rx8025_sysfs_unregister(&client->dev);
- return 0;
+ return devm_rtc_register_device(rx8025->rtc);
}
static struct i2c_driver rx8025_driver = {
@@ -581,7 +573,6 @@ static struct i2c_driver rx8025_driver = {
.name = "rtc-rx8025",
},
.probe = rx8025_probe,
- .remove = rx8025_remove,
.id_table = rx8025_id,
};
--
2.31.1
next prev parent reply other threads:[~2021-11-07 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 22:54 [PATCH 01/12] rtc: handle alarms with a minute resolution Alexandre Belloni
2021-11-07 22:54 ` [PATCH 02/12] rtc: s35390a: let the core handle the alarm resolution Alexandre Belloni
2021-11-07 22:54 ` [PATCH 03/12] rtc: rv3032: " Alexandre Belloni
2021-11-07 22:54 ` [PATCH 04/12] rtc: ab-eoz9: use RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2021-11-07 22:54 ` [PATCH 05/12] rtc: ab-eoz9: support UIE when available Alexandre Belloni
2021-11-07 22:54 ` [PATCH 06/12] rtc: ab8500: let the core handle the alarm resolution Alexandre Belloni
2021-11-09 11:47 ` Linus Walleij
2021-11-07 22:54 ` [PATCH 07/12] rtc: rx8025: switch to devm_rtc_allocate_device Alexandre Belloni
2021-11-07 22:54 ` [PATCH 08/12] rtc: rx8025: let the core handle the alarm resolution Alexandre Belloni
2021-11-07 22:54 ` [PATCH 09/12] rtc: rx8025: set range Alexandre Belloni
2021-11-07 22:54 ` [PATCH 10/12] rtc: rx8025: clear RTC_FEATURE_ALARM when alarm are not supported Alexandre Belloni
2021-11-07 22:54 ` Alexandre Belloni [this message]
2021-11-07 22:54 ` [PATCH 12/12] rtc: rx8025: use .set_offset/.read_offset Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211107225458.111068-11-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox