linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: [PATCH v5 7/9] rtc-mc146818-lib: refactor mc146818_does_rtc_work
Date: Fri,  7 Jan 2022 13:49:32 +0100	[thread overview]
Message-ID: <20220107124934.159878-8-mat.jonczyk@o2.pl> (raw)
In-Reply-To: <20220107124934.159878-1-mat.jonczyk@o2.pl>

Refactor mc146818_does_rtc_work() so that it uses mc146818_avoid_UIP().
It is enough to call mc146818_avoid_UIP() with no callback.

Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

---

v4: fixed a mistake in the patch description.

 drivers/rtc/rtc-mc146818-lib.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
index 34a1ed61a4f9..75dfad22b31a 100644
--- a/drivers/rtc/rtc-mc146818-lib.c
+++ b/drivers/rtc/rtc-mc146818-lib.c
@@ -84,22 +84,7 @@ EXPORT_SYMBOL_GPL(mc146818_avoid_UIP);
  */
 bool mc146818_does_rtc_work(void)
 {
-	int i;
-	unsigned char val;
-	unsigned long flags;
-
-	for (i = 0; i < 20; i++) {
-		spin_lock_irqsave(&rtc_lock, flags);
-		val = CMOS_READ(RTC_FREQ_SELECT);
-		spin_unlock_irqrestore(&rtc_lock, flags);
-
-		if ((val & RTC_UIP) == 0)
-			return true;
-
-		mdelay(1);
-	}
-
-	return false;
+	return mc146818_avoid_UIP(NULL, NULL);
 }
 EXPORT_SYMBOL_GPL(mc146818_does_rtc_work);
 
-- 
2.25.1


  parent reply	other threads:[~2022-01-07 12:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 12:49 [PATCH v5 0/9] rtc-cmos,rtc-mc146818-lib: fixes Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 1/9] rtc-cmos: take rtc_lock while reading from CMOS Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 2/9] rtc: change return values of mc146818_get_time() Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 3/9] Check return value from mc146818_get_time() Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 4/9] rtc-mc146818-lib: fix RTC presence check Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 5/9] rtc-mc146818-lib: extract mc146818_avoid_UIP Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 6/9] rtc-mc146818-lib: refactor mc146818_get_time Mateusz Jończyk
2022-01-07 12:49 ` Mateusz Jończyk [this message]
2022-01-07 12:49 ` [PATCH v5 8/9] rtc-cmos: avoid UIP when reading alarm time Mateusz Jończyk
2022-01-07 12:51   ` [DEBUG PATCH v5] rtc-cmos: cmos_read_alarm bug demonstration Mateusz Jończyk
2022-03-29 20:02   ` [PATCH v5 8/9] rtc-cmos: avoid UIP when reading alarm time Mateusz Jończyk
2022-01-07 12:49 ` [PATCH v5 9/9] rtc-cmos: avoid UIP when writing " Mateusz Jończyk
2022-01-07 13:03 ` [PATCH v5 0/9] rtc-cmos,rtc-mc146818-lib: fixes Alexandre Belloni
2022-01-07 13:14   ` Mateusz Jończyk
2022-01-07 15:34     ` [PATCH] RFC: rtc-mc146818-lib: wait longer for UIP to clear Mateusz Jończyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107124934.159878-8-mat.jonczyk@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).