* [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
@ 2022-01-11 7:19 Dan Carpenter
2022-01-11 9:46 ` Mateusz Jończyk
2022-01-16 22:34 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-01-11 7:19 UTC (permalink / raw)
To: Giovanni Cabiddu, Mateusz Jończyk
Cc: Herbert Xu, David S. Miller, Alessandro Zummo, Alexandre Belloni,
Marco Chiappero, Fiona Trahe, Wojciech Ziemba, Tomasz Kowalik,
qat-linux, linux-crypto, linux-rtc, kernel-janitors
The mc146818_get_time() function returns zero on success or negative
a error code on failure. It needs to be type int.
Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
include/linux/mc146818rtc.h | 2 +-
drivers/rtc/rtc-mc146818-lib.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h
index 67fb0a12becc..808bb4cee230 100644
--- a/include/linux/mc146818rtc.h
+++ b/include/linux/mc146818rtc.h
@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
#endif /* ARCH_RTC_LOCATION */
bool mc146818_does_rtc_work(void);
-unsigned int mc146818_get_time(struct rtc_time *time);
+int mc146818_get_time(struct rtc_time *time);
int mc146818_set_time(struct rtc_time *time);
bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
index f62e658cbe23..7f689f1bafc5 100644
--- a/drivers/rtc/rtc-mc146818-lib.c
+++ b/drivers/rtc/rtc-mc146818-lib.c
@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
p->ctrl = CMOS_READ(RTC_CONTROL);
}
-unsigned int mc146818_get_time(struct rtc_time *time)
+int mc146818_get_time(struct rtc_time *time)
{
struct mc146818_get_time_callback_param p = {
.time = time
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
2022-01-11 7:19 [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time() Dan Carpenter
@ 2022-01-11 9:46 ` Mateusz Jończyk
2022-01-16 22:34 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Mateusz Jończyk @ 2022-01-11 9:46 UTC (permalink / raw)
To: Dan Carpenter, Giovanni Cabiddu
Cc: Herbert Xu, David S. Miller, Alessandro Zummo, Alexandre Belloni,
Marco Chiappero, Fiona Trahe, Wojciech Ziemba, Tomasz Kowalik,
qat-linux, linux-crypto, linux-rtc, kernel-janitors
W dniu 11.01.2022 o 08:19, Dan Carpenter pisze:
> The mc146818_get_time() function returns zero on success or negative
> a error code on failure. It needs to be type int.
>
> Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Indeed, thanks for spotting this.
Reviewed-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> ---
> include/linux/mc146818rtc.h | 2 +-
> drivers/rtc/rtc-mc146818-lib.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h
> index 67fb0a12becc..808bb4cee230 100644
> --- a/include/linux/mc146818rtc.h
> +++ b/include/linux/mc146818rtc.h
> @@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
> #endif /* ARCH_RTC_LOCATION */
>
> bool mc146818_does_rtc_work(void);
> -unsigned int mc146818_get_time(struct rtc_time *time);
> +int mc146818_get_time(struct rtc_time *time);
> int mc146818_set_time(struct rtc_time *time);
>
> bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
> diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
> index f62e658cbe23..7f689f1bafc5 100644
> --- a/drivers/rtc/rtc-mc146818-lib.c
> +++ b/drivers/rtc/rtc-mc146818-lib.c
> @@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
> p->ctrl = CMOS_READ(RTC_CONTROL);
> }
>
> -unsigned int mc146818_get_time(struct rtc_time *time)
> +int mc146818_get_time(struct rtc_time *time)
> {
> struct mc146818_get_time_callback_param p = {
> .time = time
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
2022-01-11 7:19 [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time() Dan Carpenter
2022-01-11 9:46 ` Mateusz Jończyk
@ 2022-01-16 22:34 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2022-01-16 22:34 UTC (permalink / raw)
To: Giovanni Cabiddu, Dan Carpenter, Mateusz Jończyk
Cc: Alexandre Belloni, qat-linux, linux-crypto, Fiona Trahe,
Alessandro Zummo, David S. Miller, Tomasz Kowalik,
Marco Chiappero, kernel-janitors, linux-rtc, Herbert Xu,
Wojciech Ziemba
On Tue, 11 Jan 2022 10:19:22 +0300, Dan Carpenter wrote:
> The mc146818_get_time() function returns zero on success or negative
> a error code on failure. It needs to be type int.
>
>
Applied, thanks!
[1/1] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
commit: 7372971c1be5b7d4fdd8ad237798bdc1d1d54162
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-16 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 7:19 [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time() Dan Carpenter
2022-01-11 9:46 ` Mateusz Jończyk
2022-01-16 22:34 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).