public inbox for linux-rtc@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Shuah Khan <shuah@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] selftests: rtc: Increase test timeout so that all tests run
Date: Wed, 12 Jan 2022 14:10:56 -0500	[thread overview]
Message-ID: <20220112191056.c7gflbokgm2pispg@notapiano> (raw)
In-Reply-To: <Yd8IdbGybWBOa5qe@piout.net>

On Wed, Jan 12, 2022 at 05:57:25PM +0100, Alexandre Belloni wrote:
> On 12/01/2022 11:53:59-0500, Nícolas F. R. A. Prado wrote:
> > The timeout setting for the rtc kselftest is currently 90 seconds.
> > However, two of the tests set alarms, which take one minute to complete
> > each. So the timeout should be at least 120. Set it to 180, so that all
> > tests are able to complete and still have some slack.
> 
> Hum, I don't get the logic from that, a test takes up to 60 seconds and
> the timeout is 90s per test so we already have plenty of slack there.

Actually I did re-test locally and it is an issue since the 90s timeout is not
per-test, but to the whole rtc test suite. Also it requires running the test
through the selftest runner, and since the alarm is set to the next top of the
minute, you might get lucky and it might all take less than 90 seconds.

However none of this was clear in my original commit message, so I'll send a v2
with a better explanation.

Thanks,
Nícolas

      reply	other threads:[~2022-01-12 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 16:53 [PATCH] selftests: rtc: Increase test timeout so that all tests run Nícolas F. R. A. Prado
2022-01-12 16:57 ` Alexandre Belloni
2022-01-12 19:10   ` Nícolas F. R. A. Prado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220112191056.c7gflbokgm2pispg@notapiano \
    --to=nfraprado@collabora.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox