From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 931B5C433F5 for ; Wed, 18 May 2022 13:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238244AbiERNr6 (ORCPT ); Wed, 18 May 2022 09:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238142AbiERNr6 (ORCPT ); Wed, 18 May 2022 09:47:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A3F841A8E00 for ; Wed, 18 May 2022 06:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652881675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=u2KtS7a0V1qX4x/uzAxmwYggLko6jxdiXgkpP8ZKnHE=; b=AVUdj26/DQbehIkya799bh1cHf+UVWthFfi2STr2/I2RcbijzQIDM+2p3d2Y0b/Qa1cfTJ GNbKxKXLj12oSPNVJTS2q3BzVo+sEyZYk8mcMtSRSCzLmsJBOmyN05Psxjw5aW3M09r/JK JgEqEW4Xp8YDVnrP+iSrlXJER6+o9R0= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-312-MAPvXIkDM_yW8zwBbWqTbw-1; Wed, 18 May 2022 09:47:54 -0400 X-MC-Unique: MAPvXIkDM_yW8zwBbWqTbw-1 Received: by mail-qt1-f198.google.com with SMTP id a18-20020ac85b92000000b002f3c5e0a098so1702136qta.7 for ; Wed, 18 May 2022 06:47:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u2KtS7a0V1qX4x/uzAxmwYggLko6jxdiXgkpP8ZKnHE=; b=q8vXD1OssRAsjShz6IEwzYpExkL7B5KqiuXUnAzvvrYneZHPpJHVeJgGBka5Duttqa hOzGWl9C7YLH5fnqealsf1RsMna7eFZU65RhFCvnS1wz3Ok+cQloleUTJ4fyn+1F1yeR WL5OkxFiKbsTu8ke9pvyvWcgC+QDPohdQqyMTShPbb7a1I4jXtShgT47lccU+GPZX2+j WGPVw3OOqamgrsNpmXE7KcwVnud2uXaj+j33o0VmXk6Cvg/DksSJHzu4hi6u6bVi4cMA xvITWHfRp7DnACycO76RJ24sbUvrBscCSwt1tLoHXsLFTTkeiprRYu1kxpLcsFuLDzed MMvQ== X-Gm-Message-State: AOAM533U0VPkCIGC1XOJm93t2BTnnfHL6MKswVuAXyko5tQwX/ERagMW CublMedbBZKOxBBT+Gx+Do3igg+24UVzCEKt1Rr2EX1PwXENbLozSgFNVt2N+yC5ZXgAGrnitpO ExF1Mac+r/vAvMUwhJi+N X-Received: by 2002:a05:6214:f29:b0:461:cf47:63eb with SMTP id iw9-20020a0562140f2900b00461cf4763ebmr12894730qvb.70.1652881673946; Wed, 18 May 2022 06:47:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtgXvKlLmGN2occDj9JylwKZjwpVnZVseYzumo/m3mhT0POXGLcciAWfqMEDj6vc6Lg/6L8g== X-Received: by 2002:a05:6214:f29:b0:461:cf47:63eb with SMTP id iw9-20020a0562140f2900b00461cf4763ebmr12894720qvb.70.1652881673798; Wed, 18 May 2022 06:47:53 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id he30-20020a05622a601e00b002f39b99f678sm1207547qtb.18.2022.05.18.06.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:47:53 -0700 (PDT) From: Tom Rix To: miquel.raynal@bootlin.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, nathan@kernel.org, ndesaulniers@google.com Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] rtc: rzn1: initialize val in rzn1_rtc_set_offset Date: Wed, 18 May 2022 09:47:47 -0400 Message-Id: <20220518134747.3215597-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The clang build fails with rtc-rzn1.c:291:3: error: variable 'val' is uninitialized when used here [-Werror,-Wuninitialized] val |= RZN1_RTC_SUBU_DEV; ^~~ The val variable in rzn1_rtc_set_offset() is never initialized so the series of |= operations in the function will start with a garbage value. So initialize val to 0. Fixes: be4a11cf98af ("rtc: rzn1: Add oscillator offset support") Signed-off-by: Tom Rix --- drivers/rtc/rtc-rzn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index 980ade8c9601..0b4bf6e43464 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -272,7 +272,7 @@ static int rzn1_rtc_set_offset(struct device *dev, long offset) struct rzn1_rtc *rtc = dev_get_drvdata(dev); unsigned int steps; int stepsh, stepsl; - u32 val; + u32 val = 0; int ret; /* -- 2.27.0