From: Dan Carpenter <dan.carpenter@oracle.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Michel Pollet <michel.pollet@bp.renesas.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: rzn1: Fix error code in probe
Date: Thu, 19 May 2022 17:26:46 +0300 [thread overview]
Message-ID: <20220519142646.GA23160@kadam> (raw)
In-Reply-To: <20220519160821.14230810@xps-13>
On Thu, May 19, 2022 at 04:08:21PM +0200, Miquel Raynal wrote:
> Hi Dan,
>
> dan.carpenter@oracle.com wrote on Thu, 19 May 2022 16:56:19 +0300:
>
> > There is a copy and paste error so this code returns the wrong variable.
> >
> > Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
>
> The Fixes here will point to an unknown id once pulled by Linus.
No, it shouldn't be an issue.
I'm assuming based on the S-o-b tags that this goes through Alexandre's
tree. The hash will stay the same unless Alexandre rebases.
When a maintainer rebases then it's their responsibility to update the
Fixes tags. Most likely the maintainer just going to fold the fixes
patches into the original patch so it's a moot issue. There are
automated checks run on linux-next for incorrect Fixes tags so, you
know, don't rebase and then push immediately; first let the autobuilders
check for stuff like this.
regards,
dan carpenter
next prev parent reply other threads:[~2022-05-19 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 13:56 [PATCH] rtc: rzn1: Fix error code in probe Dan Carpenter
2022-05-19 14:08 ` Miquel Raynal
2022-05-19 14:26 ` Dan Carpenter [this message]
2022-05-24 23:22 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519142646.GA23160@kadam \
--to=dan.carpenter@oracle.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=michel.pollet@bp.renesas.com \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox